Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Update language support#1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jhildenbiddle merged 8 commits intodevelopfromupdate-language-support
Feb 5, 2021
Merged

Conversation

@jhildenbiddle
Copy link
Member

@jhildenbiddlejhildenbiddle commentedFeb 4, 2021
edited
Loading

Summary

  1. Dynamically set the HTMLlang attribute based on URL hash. This attribute must be set properly in order to trigger auto-translation features on applicable Chromium-based browsers (Chrome, Edge). Note that this fix works only for the initial page load aslang attribute changes are not recognized on hash change. For example:

    https://docsify.js.org/

    <htmllang="en">

    https://docsify.js.org/#/zh-cn/

    <htmllang="zh-cn">
  2. Remove thewrite-a-plugin.md alias as it appears to be unnecessary

  3. Add Russian and Spanish search-related label translations

What kind of change does this PR introduce? (check at least one)

  • Feature
  • Docs

If changing the UI of default theme, please provide thebefore/after screenshot:

  • Before (notice the lack of the translation option in the URL bar)
    Chrome1

  • After
    Chrome2

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercelbot commentedFeb 4, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/1stwj93rt
✅ Preview:https://docsify-preview-git-update-language-support.docsify-core.vercel.app

@jhildenbiddlejhildenbiddle requested review froma team andsy-records and removed request forsy-recordsFebruary 4, 2021 21:11
@jhildenbiddlejhildenbiddle changed the titleUpdate language supportfix: Update language supportFeb 4, 2021
@codesandbox-ci
Copy link

codesandbox-cibot commentedFeb 4, 2021
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit2626036:

SandboxSource
docsify-templateConfiguration

sy-records
sy-records previously approved these changesFeb 5, 2021
@sy-records
Copy link
Member

It seems that the test snapshot file needs to be updated

Co-authored-by: 沈唁 <52o@qq52o.cn>
@jhildenbiddle
Copy link
MemberAuthor

jhildenbiddle commentedFeb 5, 2021
edited
Loading

It seems that the test snapshot file needs to be updated

@sy-records Yep. Good catch. I didn't test locally because I need the changes from#1487 to test on my ARM-based Mac. Should be all set now.

sy-records reacted with thumbs up emoji

@sy-recordssy-records requested a review froma teamFebruary 5, 2021 01:07
Copy link
Member

@Koooooo-7Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Koooooo-7Koooooo-7Koooooo-7 approved these changes

@sy-recordssy-recordssy-records approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhildenbiddle@sy-records@Koooooo-7

[8]ページ先頭

©2009-2025 Movatter.jp