NotificationsYou must be signed in to change notification settings
Fork5.8k
Star30.6k

fix: upgrade dompurify from 2.2.2 to 2.2.6#1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sy-records merged 1 commit intodocsifyjs:developfromsy-records:dompurify

Feb 4, 2021

Merged

fix: upgrade dompurify from 2.2.2 to 2.2.6#1483

sy-records merged 1 commit intodocsifyjs:developfromsy-records:dompurify

Feb 4, 2021

Conversation

Copy link

Member

sy-records commentedJan 29, 2021

Replace#1470

fix: upgrade dompurify from 2.2.2 to 2.2.6

ed7fa16

Copy link

vercelbot commentedJan 29, 2021•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/l6tfu5hbe
✅ Preview:https://docsify-preview-git-fork-sy-records-dompurify.docsify-core.now.sh

vercelbotdeployed toPreview

January 29, 2021 01:08

View deployment

sy-records requested a review froma team

January 29, 2021 01:08

Copy link

codesandbox-cibot commentedJan 29, 2021

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commited7fa16:

Sandbox	Source
docsify-template	Configuration

Koooooo-7 reviewed

Jan 29, 2021

View reviewed changes

Copy link

Member

Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it seems there has thesecurity/snyk issue on CI.
@anikethsaha could u plz check and fix it intead of manual upgrade？

Copy link

Member

anikethsaha commentedJan 29, 2021

Not sure whether I get this correctly but you are asking for a PR from snyk ?@Koooooo-7

Copy link

Member

Koooooo-7 commentedJan 29, 2021

Not sure whether I get this correctly but you are asking for a PR from snyk ?@Koooooo-7

yup, the PR of snyk always deletes the dependencies aboutvue inpackage-lock.json. f.e see#1470 .

Copy link

Member

Koooooo-7 commentedJan 29, 2021

I guess we need move thevue fromdevDependencies todependencies .

Copy link

MemberAuthor

sy-records commentedJan 29, 2021•
edited
Loading

The reason I closed#1470 was because it was out of date, 4 versions behind

Copy link

MemberAuthor

sy-records commentedJan 29, 2021

Maybe snyk doesn't recognize this style

https://github.com/docsifyjs/docsify/blob/develop/package.json#L106-L107

sy-records merged commiteee9507 intodocsifyjs:develop

Feb 4, 2021

sy-records deleted the dompurify branch

February 4, 2021 00:30

Copy link

Member

jhildenbiddle commentedFeb 4, 2021

Maybe snyk doesn't recognize this style
https://github.com/docsifyjs/docsify/blob/develop/package.json#L106-L107

@sy-records -- Let's ping Snyk and let them know that their system appears unable to determine when two versions of the same library are listed as dependencies. Otherwise we're just going to run into this issue over and over again. Sounds like@anikethsaha maintains our account?

Copy link

Member

anikethsaha commentedFeb 5, 2021

Maybe snyk doesn't recognize this style
https://github.com/docsifyjs/docsify/blob/develop/package.json#L106-L107
@sy-records -- Let's ping Snyk and let them know that their system appears unable to determine when two versions of the same library are listed as dependencies. Otherwise we're just going to run into this issue over and over again. Sounds like@anikethsaha maintains our account?

I think@sy-records does have the access, right ?
if not please tell me how to give access, I tried but it wasnt successfull.