NotificationsYou must be signed in to change notification settings
Fork5.8k
Star30.6k

fix: font-size changing for code in headings#1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jhildenbiddle merged 8 commits intodocsifyjs:developfromYash-Singh1:develop

Feb 5, 2021

Merged

fix: font-size changing for code in headings#1456

jhildenbiddle merged 8 commits intodocsifyjs:developfromYash-Singh1:develop

Feb 5, 2021

Conversation

Copy link

Contributor

Yash-Singh1 commentedDec 28, 2020

Summary

What kind of change does this PR introduce? (check at least one)

Bugfix
Feature
Code style update
Refactor
Docs
Build-related changes
Repo settings
Other, please describe:

If changing the UI of the default theme, please provide thebefore/after screenshot:

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

Chrome
Firefox
Safari
Edge
IE

If adding anew feature, the PR's description includes:

A convincing reason for adding this feature
Related documents have been updated
Related tests have been updated

To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.

Fix font-size changing for code in headings

3e3b351

Copy link

vercelbot commentedDec 28, 2020•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/a4onqhfnz
✅ Preview:https://docsify-preview-git-fork-yash-singh1-develop.docsify-core.vercel.app

vercelbotdeployed toPreview

December 28, 2020 00:09

View deployment

Copy link

codesandbox-cibot commentedDec 28, 2020•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit4b61b11:

Sandbox	Source
docsify-template	Configuration

Copy link

ContributorAuthor

Yash-Singh1 commentedDec 28, 2020

Before:

After:

Copy link

Member

trusktr commentedDec 28, 2020•
edited
Loading

Thanks@Yash-Singh1! This bugged me before too, and I put custom style on my site.

@docsifyjs/reviewers should this sort of change be saved for v5? It is an ideal change, but does have some chance (even if small) to break someone's v4 site.