Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: slugs are still broken when headings contain html#1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sy-records merged 2 commits intodocsifyjs:developfromsy-records:fix/1442
Dec 18, 2020

Conversation

@sy-records
Copy link
Member

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide thebefore/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)

fix#1442

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding anew feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.

@sy-recordssy-records requested review fromKoooooo-7 andjhildenbiddle and removed request forKoooooo-7December 9, 2020 10:55
@vercel
Copy link

vercelbot commentedDec 9, 2020
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/ih0zul73y
✅ Preview:https://docsify-preview-git-fix-1442.docsify-core.now.sh

@codesandbox-ci
Copy link

codesandbox-cibot commentedDec 9, 2020
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit1ecdafb:

SandboxSource
docsify-templateConfiguration

Copy link
Member

@jhildenbiddlejhildenbiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jhildenbiddlejhildenbiddlejhildenbiddle approved these changes

@anikethsahaanikethsahaanikethsaha approved these changes

@trusktrtrusktrAwaiting requested review from trusktr

@Koooooo-7Koooooo-7Awaiting requested review from Koooooo-7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#50 is incomplete, slugs are still broken when headings contain html

3 participants

@sy-records@jhildenbiddle@anikethsaha

[8]ページ先頭

©2009-2025 Movatter.jp