NotificationsYou must be signed in to change notification settings
Fork5.8k
Star30.6k

Fix/lint warnings#1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jhildenbiddle merged 3 commits intodevelopfromfix/lint-warnings

Oct 9, 2020

Merged

Fix/lint warnings#1388

jhildenbiddle merged 3 commits intodevelopfromfix/lint-warnings

Oct 9, 2020

Conversation

Copy link

Member

jhildenbiddle commentedOct 8, 2020

Summary

Fix lint warning during build

What kind of change does this PR introduce? (check at least one)

Bugfix
Feature
Code style update
Refactor
Docs
Build-related changes
Repo settings
Other, please describe:

Does this PR introduce a breaking change? (check one)

jhildenbiddleand others added3 commits

October 7, 2020 15:40

Fix eslint warnings

73df174

Merge branch 'fix-790' into fix/lint-warnings

82f9c6f

Merge branch 'develop' into fix/lint-warnings

05350f3

Copy link

vercelbot commentedOct 8, 2020•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/3ztmvbsj4
✅ Preview:https://docsify-preview-git-fix-lint-warnings.docsify-core.vercel.app

vercelbotdeployed toPreview

October 8, 2020 21:10

View deployment

jhildenbiddle added the buildThis is related to build process label

Oct 8, 2020

Copy link

codesandbox-cibot commentedOct 8, 2020

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit05350f3:

Sandbox	Source
docsify-template	Configuration

jhildenbiddle requested review fromKoooooo-7,anikethsaha,sy-records andtrusktr

October 8, 2020 21:18

sy-records approved these changes

Oct 9, 2020

View reviewed changes

Copy link

Member

sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Koooooo-7 approved these changes

Oct 9, 2020

View reviewed changes

Copy link

Member

sy-records commentedOct 9, 2020

Usesquash and merge

jhildenbiddle merged commit0afbf96 intodevelop

Oct 9, 2020

sy-records deleted the fix/lint-warnings branch

October 9, 2020 03:00

trusktr added a commit that referenced this pull request

Nov 2, 2020

Merge branch 'develop' into fix-validating-remote-content

d516198

* develop: (81 commits)  fix: upgrade dompurify from 2.1.0 to 2.1.1 (#1402)  fix: upgrade dompurify from 2.0.17 to 2.1.0 (#1397)  fix: search on homepage test (#1398)  fix: the sidebar links to another site. (#1336)  fix: Can't search homepage content (#1391)  fix: upgrade debug from 4.1.1 to 4.3.0 (#1390)  fix: packages/docsify-server-renderer/package.json & packages/docsify-server-renderer/package-lock.json to reduce vulnerabilities (#1389)  Fix eslint warnings (#1388)  docs: add crossOriginLinks configurations details. (#1386)  Remove Cypress screenshots  Fix friendly message display  Add Vue 3 compatibility  Show dir listing & help msg for manual instance  Add NODE_MODULES_URL global  Jest + Playwright Testing (#1276)  update doc (#1381)  Fix scroll event end value  fix: upgrade docsify from 4.11.4 to 4.11.6 (#1373)  chore(deps): bump node-fetch in /packages/docsify-server-renderer (#1370)  test: fix cannot search list content (#1367)  ...