Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: search cannot search list content#1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sy-records merged 2 commits intodocsifyjs:developfromsy-records:fix-search
Sep 3, 2020

Conversation

@sy-records
Copy link
Member

Summary

fix: search cannot search list content

# Testbalabala...* this is content* this is content

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide thebefore/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding anew feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.

@vercel
Copy link

vercelbot commentedAug 27, 2020
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/cy4jxf67e
✅ Preview:https://docsify-preview-git-fork-sy-records-fix-search.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-cibot commentedAug 27, 2020
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commitf90e4f6:

SandboxSource
docsify-templateConfiguration

Copy link
Member

@anikethsahaanikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

As the infra for plugin testing is not set up yet, I think we can merge this. Though if you can setup or add tests for this, it would be great.

@sy-records
Copy link
MemberAuthor

As the infra for plugin testing is not set up yet, I think we can merge this. Though if you can setup or add tests for this, it would be great.

I also want to add tests, but I don't know how to write them...

anikethsaha reacted with thumbs up emojianikethsaha reacted with laugh emoji

@sy-recordssy-records linked an issueSep 2, 2020 that may beclosed by this pull request
1 task
@Koooooo-7
Copy link
Member

...I m working on the test rn. 😅

@sy-records
Copy link
MemberAuthor

Well, then you can resubmit the PR for changes if you have questions.

Koooooo-7 added a commit to Koooooo-7/docsify that referenced this pull requestSep 3, 2020
@Koooooo-7Koooooo-7 mentioned this pull requestSep 3, 2020
19 tasks
@sy-recordssy-records mentioned this pull requestFeb 5, 2021
3 tasks
@Jir4Jir4 mentioned this pull requestFeb 5, 2021
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@anikethsahaanikethsahaanikethsaha approved these changes

@Koooooo-7Koooooo-7Koooooo-7 approved these changes

@jhildenbiddlejhildenbiddleAwaiting requested review from jhildenbiddle

@trusktrtrusktrAwaiting requested review from trusktr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search Plugin doesn't indexes text inside a bulleted and numbered list

3 participants

@sy-records@Koooooo-7@anikethsaha

[8]ページ先頭

©2009-2025 Movatter.jp