Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Vue Reactivity#1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jhildenbiddle merged 11 commits intodevelopfromfix-790
Oct 8, 2020
Merged

Fix Vue Reactivity#1271

jhildenbiddle merged 11 commits intodevelopfromfix-790
Oct 8, 2020

Conversation

@jhildenbiddle
Copy link
Member

@jhildenbiddlejhildenbiddle commentedJul 5, 2020
edited
Loading

Fixes#788#790#1074#1252#1364

  • Fix inability to instantiate reactive Vue components by 1) handling each child of#main instead of#main itself and 2) skipping elements that are already Vue instances
  • Retain previous behavior of handling basic Vue rendering without the need for a markdown<script> tag.
  • Add Vue3 support
  • Update documentation and add live Vue examples
  • Updateindex.html files to include Vue.js
  • UpdateCypress Jest+Playwright e2e tests

Summary: Docsify was mounting#main as a Vue component on every page change when it detected Vue.js, presumably to process basic Vue content without requiring a<script> tag in each markdown file. The issue is that this was happeningafter users had already instantiated child elements of#main as Vue components, destroying those instances.

- Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2)  skipping elements that are already Vue instances- Retain previous behavior of processing basic Vue rendering without the need for a markdown <script> tag.- Update documentation and add live Vue examples- Update `index.html` files to include Vue.js and Vuep (CSS+JS)
# Conflicts:#docs/index.html
@vercel
Copy link

vercelbot commentedJul 5, 2020
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/gw3jsrcph
✅ Preview:https://docsify-preview-git-fix-790.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-cibot commentedJul 5, 2020
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit4f6148d:

SandboxSource
docsify-templateConfiguration

Copy link
Member

@anikethsahaanikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is really awesome

Koooooo-7
Koooooo-7 previously approved these changesJul 5, 2020
Copy link
Member

@Koooooo-7Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome ! 👍

anikethsaha
anikethsaha previously approved these changesJul 5, 2020
sy-records
sy-records previously approved these changesJul 5, 2020
trusktr
trusktr previously requested changesJul 5, 2020
Copy link
Member

@trusktrtrusktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a good change, but let's add unit tests.

@anikethsaha
Copy link
Member

This is a good change, but let's add unit tests.

tests fixtures (e2e-cypress) have been updated. But yea unit/integration tests would be great to add. But is it possible to do unit testing for this change ? if so, it would be great to add.

@jhildenbiddlejhildenbiddle linked an issueJul 5, 2020 that may beclosed by this pull request
1 task
- When Vue.js is detected, markdown `<script>` is not executed when executeScript is `false` (matches previous behavior)- Minor code tweaks that do not affect functonality
anikethsaha
anikethsaha previously approved these changesOct 7, 2020
This was linked to issuesOct 8, 2020
@jhildenbiddlejhildenbiddle merged commit761210c intodevelopOct 8, 2020
This was referencedOct 8, 2020
@jhildenbiddlejhildenbiddle deleted the fix-790 branchOctober 8, 2020 22:07
@sy-recordssy-records mentioned this pull requestFeb 5, 2021
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@anikethsahaanikethsahaanikethsaha approved these changes

@sy-recordssy-recordssy-records approved these changes

@trusktrtrusktrAwaiting requested review from trusktr

@Koooooo-7Koooooo-7Awaiting requested review from Koooooo-7

Assignees

@jhildenbiddlejhildenbiddle

Labels

vuejsrelated to Vue.js

Projects

None yet

Milestone

No milestone

6 participants

@jhildenbiddle@anikethsaha@trusktr@Koooooo-7@sy-records

[8]ページ先頭

©2009-2025 Movatter.jp