Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
fix(parser): correctly parse record and tuple tokens#13418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
babel-bot commentedJun 3, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Build successful! You can test your changes in the REPL here:https://babeljs.io/repl/build/46719/ |
fedeci commentedJun 3, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I noted that we don't have token specific fixtures, should we add those? constructor(state:State){this.type=state.type;if(state.value!==undefined){this.value=state.value;}this.start=state.start;this.end=state.end;this.loc=newSourceLocation(state.startLoc,state.endLoc);} but no tests are throwing, since they are not writing |
fisker commentedJun 3, 2021
Thanks for the quick fix, have you checked |
nicolo-ribaudo commentedJun 3, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fedeci You can add a new |
JLHwung commentedJun 3, 2021
We need similar fix for |
KFlash commentedJun 3, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That token constructor code is super slow :) Why there is a need for a |
packages/babel-parser/test/fixtures/tokens/record-and-tuple/brace-bar/output.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
codesandbox-cibot commentedJun 4, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit3d15e07:
|
#{ and#[KFlash commentedJun 9, 2021
@JLHwung No plans to fix the performance issues? |
JLHwung commentedJun 9, 2021
@KFlash I am aware of the performance issue here, but fixing the performance falls out of the scope of this PR and thus should be addressed in another PR. |
Uh oh!
There was an error while loading.Please reload this page.
#{and#[tokens now hold the correct location.|]and|}are now finished as tokens and not operators.