- Notifications
You must be signed in to change notification settings - Fork2.1k
consume new @actions/github for GHES support#236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -75,8 +74,8 @@ async function downloadArchive( | |||
| ref: string, | |||
| commit: string | |||
| ): Promise<Buffer> { | |||
| const octokit = new github.GitHub(authToken, {baseUrl: urlHelper.getApiUrl()}) | |||
| const params: ReposGetArchiveLinkParams = { | |||
| const octokit = new github.GitHub(authToken) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let the toolkit set thebaseUrl
| import {default as uuid} from 'uuid/v4' | ||
| import {ReposGetArchiveLinkParams} from '@octokit/rest' | ||
| import {Octokit} from '@octokit/rest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wasnt able to import directly anymore (compat break)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Uh oh!
There was an error while loading.Please reload this page.
Let the toolkit set the baseUrl (GHES vs Dotcom) when constructing the Octokit REST client