This repository was archived by the owner on Sep 19, 2023. It is now read-only.

openjdk/jdk19Public archive

NotificationsYou must be signed in to change notification settings
Fork55
Star39

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large#163

Closed

vnkozlov wants to merge1 commit intoopenjdk:masterfromvnkozlov:JDK-8292260

Closed

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large#163

vnkozlov wants to merge1 commit intoopenjdk:masterfromvnkozlov:JDK-8292260

Conversation

Copy link

vnkozlov commentedAug 12, 2022•
edited by openjdkbot
Loading

Regressions have been observed with the 11.0.16 and following releases. SeeJDK-8291665 andJDK-8288184. There might be more code-shapes out in the wild which trigger similar issues. Therefore we'd like to back out the patch ofJDK-8279219. Risk is obviously that the fix ofJDK-8279219 would no longer be there and potential other issues caused by the absence ofJDK-8279219 (that we don't know yet). Yet it gets us back to where we were before JDK-8279219. It seems the safest option moving forward.

Backout is not clean because of additional changes ingraphKit.cpp and testTestFailedAllocationBadGraph.java.

I verified changes with test case fromJDK-8288184.

Passed tier1-5.

Progress

Change must be properly reviewed (1 review required, with at least 1Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewers

Vladimir Ivanov (@iwanowww -Reviewer)

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.org/jdk19 pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/163.diff

8292260: Backout [REDO] C2 crash when allocating array of size too large

f1eb232

Copy link

bridgekeeperbot commentedAug 12, 2022

👋 Welcome back kvn! A progress list of the required criteria for merging this PR intomaster will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

Copy link

openjdkbot commentedAug 12, 2022

@vnkozlov The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the/label pull request command.

openjdkbot added the hotspot-compilerhotspot-compiler-dev@openjdk.org label

Aug 12, 2022

vnkozlov marked this pull request as ready for review

August 12, 2022 17:40

openjdkbot added the rfrPull request is ready for review label

Aug 12, 2022

Copy link

mlbridgebot commentedAug 12, 2022

Webrevs

00:Full (f1eb2326)

iwanowww approved these changes

Aug 12, 2022

View reviewed changes

Copy link

Contributor

iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good.

Copy link

openjdkbot commentedAug 12, 2022

@vnkozlov This change now passes allautomated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the fileCONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeReviewed-by: vlivanov

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to themaster branch. If another commit should be pushed before you perform the/integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the/integrate command for further details.

➡️ To integrate this PR with the above commit message to themaster branch, type/integrate in a new comment.