Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large#350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@jerboaa
Copy link
Contributor

@jerboaajerboaa commentedAug 12, 2022•
edited by openjdkbot
Loading

PR to backout the change ofJDK-8279219. I'll change this to the proper backport title once JDK 19 backout is done.

Progress

  • Change must be properly reviewed (1 review required, with at least 1Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewers

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.org/jdk17u pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/350.diff

@bridgekeeper
Copy link

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR intojdk17.0.4.1 will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

@openjdkopenjdkbot added the rfrPull request is ready for review labelAug 12, 2022
@mlbridge
Copy link

Webrevs

@jerboaajerboaa changed the title8292260: Backout [REDO] C2 crash when allocating array of size too large8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeAug 12, 2022
@jerboaajerboaa changed the title8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeBackport 967a28c3d85fdde6d5eb48aa0edd8f7597772469Aug 12, 2022
@openjdkopenjdkbot changed the titleBackport 967a28c3d85fdde6d5eb48aa0edd8f75977724698292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeAug 12, 2022
@openjdk
Copy link

openjdkbot commentedAug 12, 2022

This backport pull request has now been updated with issue from the originalcommit.

@openjdkopenjdkbot added the backportPort of a pull request already in a different code base labelAug 12, 2022
Copy link
Contributor

@RealCLangerRealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. JDK-8284369 is backouted by this as well but that was a specific fix for/after JDK-8279219 anyway.

@openjdk
Copy link

openjdkbot commentedAug 15, 2022

@jerboaa This change now passes allautomated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the fileCONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too largeReviewed-by: clanger

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to thejdk17.0.4.1 branch. If another commit should be pushed before you perform the/integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the/integrate command for further details.

➡️ To integrate this PR with the above commit message to thejdk17.0.4.1 branch, type/integrate in a new comment.

@openjdkopenjdkbot added the readyPull request is ready to be integrated labelAug 15, 2022
@jerboaa
Copy link
ContributorAuthor

/integrate

@openjdk
Copy link

openjdkbot commentedAug 16, 2022

Going to push as commit02fa4be.

@openjdkopenjdkbot added the integratedPull request has been integrated labelAug 16, 2022
@openjdkopenjdkbot closed thisAug 16, 2022
@openjdkopenjdkbot removed readyPull request is ready to be integrated rfrPull request is ready for review labelsAug 16, 2022
@openjdk
Copy link

openjdkbot commentedAug 16, 2022

@jerboaa Pushed as commit02fa4be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jerboaa
Copy link
ContributorAuthor

@erikj79@kevinrushforth Would either of you know why we didn't get a17.0.4.1 backport bug for this? Similar issue toopenjdk/jdk11u#49 (comment) ?

@erikj79
Copy link
Member

(I don't currently have any github notifications turned on so tagging me doesn't help)
The reason this commit hasn't been notified to JBS is that Skara is currently choking on a tag that was updated/changed in this repo. A fix for that is currently on review in SKARA-1355. I will manually go and get this unstuck for now.

@RealCLanger
Copy link
Contributor

Thanks. I already thought, force-pushing the tag would cause trouble somehwere. But it seems like in this case it helps to get the tooling more robust 😄
One other thing I noted: The backport for 17.0.4.1 now mentions "Resolved in build: master". However, the b01 tag was already set, so it should be b01. Is that an expected outcome due to working on another branch in the repo? Or because 17.0.5 tags are already in place as well?

@jerboaa
Copy link
ContributorAuthor

One other thing I noted: The backport for 17.0.4.1 now mentions "Resolved in build: master". However, the b01 tag was already set, so it should be b01.

Fixed this manually. Still interested to hear why that didn't work.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@RealCLangerRealCLangerRealCLanger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backportPort of a pull request already in a different code baseintegratedPull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerboaa@erikj79@RealCLanger
[8]ページ先頭
©2009-2025 Movatter.jp