Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility#251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@savoptik
Copy link
Contributor

@savoptiksavoptik commentedNov 11, 2021
edited by openjdkbot
Loading

Hi all,

this pull request contains a backport of commit 9c6457f2 from the openjdk/jdk repository.

The commit being backported was authored by Artem Semenov on 9 Aug 2021 and was reviewed by Alexander Zuev, Pankaj Bansal and Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • JDK-8262031: Create implementation for NSAccessibilityNavigableStaticText protocol
  • JDK-8264287: Create implementation for NSAccessibilityComboBox protocol peer
  • JDK-8264303: Create implementation for NSAccessibilityTabGroup protocol peer
  • JDK-8264292: Create implementation for NSAccessibilityList protocol peer
  • JDK-8267387: Create implementation for NSAccessibilityOutline protocol
  • JDK-8267388: Create implementation for NSAccessibilityTable protocol
  • JDK-8264286: Create implementation for NSAccessibilityColumn protocol peer
  • JDK-8264298: Create implementation for NSAccessibilityRow protocol peer
  • JDK-8264291: Create implementation for NSAccessibilityCell protocol peer

Reviewers

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/251/head:pull/251
$ git checkout pull/251

Update a local copy of the PR:
$ git checkout pull/251
$ git pull https://git.openjdk.java.net/jdk17u pull/251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 251

View PR using the GUI difftool:
$ git pr show -t 251

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/251.diff

@bridgekeeper
Copy link

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR intomaster will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

@openjdkopenjdkbot changed the titleBackport 9c6457f222e702b60fef4247c3e241c669eb94918267385: Create NSAccessibilityElement implementation for JavaComponentAccessibilityNov 11, 2021
@openjdk
Copy link

openjdkbot commentedNov 11, 2021

This backport pull request has now been updated with issues from the originalcommit.

@openjdkopenjdkbot added backportPort of a pull request already in a different code base cleanIdentical backport; no merge resolution required labelsNov 11, 2021
@openjdk
Copy link

openjdkbot commentedNov 11, 2021
edited
Loading

@savoptik This change now passes allautomated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the fileCONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility8262031: Create implementation for NSAccessibilityNavigableStaticText protocol8264287: Create implementation for NSAccessibilityComboBox protocol peer8264303: Create implementation for NSAccessibilityTabGroup protocol peer8264292: Create implementation for NSAccessibilityList protocol peer8267387: Create implementation for NSAccessibilityOutline protocol8267388: Create implementation for NSAccessibilityTable protocol8264286: Create implementation for NSAccessibilityColumn protocol peer8264298: Create implementation for NSAccessibilityRow protocol peer8264291: Create implementation for NSAccessibilityCell protocol peerReviewed-by: kizune

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to themaster branch:

  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • cc09778: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • e4425d8: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 6221d61: 8276112: Inconsistent scalar replacement debug info at safepoints
  • 24c7fe3: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • b2f4dff: 8269481: SctpMultiChannel never releases own file descriptor
  • c3de885: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • ff4f533: 8274560: JFR: Add test for OldObjectSample event when using Shenandoah
  • 23b4496: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • a1036ef: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test
  • ... and 1 more:https://git.openjdk.java.net/jdk17u/compare/3e349b436628f430946b7c571aeab09e35392ed5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the/integrate command for further details.

As you do not haveCommitter status inthis project an existing Committer must agree tosponsor your change. Possible candidates are the reviewers of this PR (@azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type/integrate in a new comment. (Afterwards, your sponsor types/sponsor in a new comment to perform the integration).

@openjdkopenjdkbot added readyPull request is ready to be integrated rfrPull request is ready for review labelsNov 11, 2021
@mlbridge
Copy link

Webrevs

@savoptik
Copy link
ContributorAuthor

/штеупкфеу

@savoptik
Copy link
ContributorAuthor

/integrate

@openjdkopenjdkbot added the sponsorPull request is ready to be sponsored labelNov 16, 2021
@openjdk
Copy link

openjdkbot commentedNov 16, 2021

@savoptik
Your change (at version9d1de83) is now ready to be sponsored by a Committer.

@forantar
Copy link

/sponsor

@openjdk
Copy link

openjdkbot commentedNov 16, 2021

Going to push as commit6f3cd6b.
Since your change was applied there have been 11 commits pushed to themaster branch:

  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • cc09778: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • e4425d8: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 6221d61: 8276112: Inconsistent scalar replacement debug info at safepoints
  • 24c7fe3: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • b2f4dff: 8269481: SctpMultiChannel never releases own file descriptor
  • c3de885: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • ff4f533: 8274560: JFR: Add test for OldObjectSample event when using Shenandoah
  • 23b4496: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • a1036ef: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test
  • ... and 1 more:https://git.openjdk.java.net/jdk17u/compare/3e349b436628f430946b7c571aeab09e35392ed5...master

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot closed thisNov 16, 2021
@openjdkopenjdkbot added integratedPull request has been integrated and removed readyPull request is ready to be integrated rfrPull request is ready for review sponsorPull request is ready to be sponsored labelsNov 16, 2021
@openjdk
Copy link

openjdkbot commentedNov 16, 2021

@forantar@savoptik Pushed as commit6f3cd6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@azuev-javaazuev-javaazuev-java approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredintegratedPull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savoptik@forantar@azuev-java

[8]ページ先頭

©2009-2025 Movatter.jp