Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

8271315: Redo: Nimbus JTree renderer properties persist across L&F changes#240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
akashche wants to merge1 commit intoopenjdk:masterfromakashche:8271315-backport

Conversation

@akashche
Copy link
Contributor

@akashcheakashche commentedNov 9, 2021•
edited by openjdkbot
Loading

Clean backport of a Swing fix. This is a follow-up to#140 .

Additional testing:

  • checked that manual NimbusJTreeSelTextColor test passes (with and without the patch)
  • checked that NimbusPropertiesDoNotImplUIResource test fails without the patch and passes with the patch

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271315: Redo: Nimbus JTree renderer properties persist across L&F changes

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/240/head:pull/240
$ git checkout pull/240

Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.java.net/jdk17u pull/240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 240

View PR using the GUI difftool:
$ git pr show -t 240

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/240.diff

@bridgekeeper
Copy link

👋 Welcome back akasko! A progress list of the required criteria for merging this PR intomaster will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

@openjdkopenjdkbot changed the titleBackport e43a907f20f99fa1f788fcbe2e99631dd01578d48271315: Redo: Nimbus JTree renderer properties persist across L&F changesNov 9, 2021
@openjdk
Copy link

openjdkbot commentedNov 9, 2021

This backport pull request has now been updated with issue from the originalcommit.

@openjdkopenjdkbot added backportPort of a pull request already in a different code base cleanIdentical backport; no merge resolution required labelsNov 9, 2021
@openjdk
Copy link

openjdkbot commentedNov 9, 2021•
edited
Loading

@akashche This change now passes allautomated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the fileCONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271315: Redo: Nimbus JTree renderer properties persist across L&F changes

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to themaster branch. If another commit should be pushed before you perform the/integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the/integrate command for further details.

➡️ To integrate this PR with the above commit message to themaster branch, type/integrate in a new comment.

@openjdkopenjdkbot added readyPull request is ready to be integrated rfrPull request is ready for review labelsNov 9, 2021
@mlbridge
Copy link

mlbridgebot commentedNov 9, 2021

Webrevs

@akashche
Copy link
ContributorAuthor

/integrate

@openjdk
Copy link

openjdkbot commentedNov 16, 2021

Going to push as commit9ff9e62.
Since your change was applied there have been 22 commits pushed to themaster branch:

  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • 6f3cd6b: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • cc09778: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • e4425d8: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 6221d61: 8276112: Inconsistent scalar replacement debug info at safepoints
  • 24c7fe3: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • ... and 12 more:https://git.openjdk.java.net/jdk17u/compare/4eeefb49b147689b3974e8257609d652083b8d25...master

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot closed thisNov 16, 2021
@openjdkopenjdkbot added integratedPull request has been integrated and removed readyPull request is ready to be integrated rfrPull request is ready for review labelsNov 16, 2021
@openjdk
Copy link

openjdkbot commentedNov 16, 2021

@akashche Pushed as commit9ff9e62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@akashcheakashche deleted the 8271315-backport branchNovember 16, 2021 12:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredintegratedPull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@akashche
[8]ページ先頭
©2009-2025 Movatter.jp