Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"#226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
zhengyu123 wants to merge1 commit intoopenjdk:masterfromzhengyu123:backport-8274338

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123zhengyu123 commentedNov 3, 2021•
edited by openjdkbot
Loading

A clean backport for parity with Oracle 17.0.3.

RedefineCrossEvent.java test passed with default, ZGC and Shenandoah GC

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/226/head:pull/226
$ git checkout pull/226

Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.java.net/jdk17u pull/226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 226

View PR using the GUI difftool:
$ git pr show -t 226

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/226.diff

@bridgekeeper
Copy link

👋 Welcome back zgu! A progress list of the required criteria for merging this PR intomaster will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

@openjdkopenjdkbot changed the titleBackport 172aed1a2d75756b140cb723133ac5fb67f7745e8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"Nov 3, 2021
@openjdk
Copy link

openjdkbot commentedNov 3, 2021

This backport pull request has now been updated with issue from the originalcommit.

@openjdkopenjdkbot added backportPort of a pull request already in a different code base cleanIdentical backport; no merge resolution required labelsNov 3, 2021
@openjdk
Copy link

openjdkbot commentedNov 3, 2021•
edited
Loading

@zhengyu123 This change now passes allautomated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the fileCONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to themaster branch. If another commit should be pushed before you perform the/integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the/integrate command for further details.

➡️ To integrate this PR with the above commit message to themaster branch, type/integrate in a new comment.

@openjdkopenjdkbot added readyPull request is ready to be integrated rfrPull request is ready for review labelsNov 3, 2021
@mlbridge
Copy link

mlbridgebot commentedNov 3, 2021

Webrevs

@zhengyu123
Copy link
ContributorAuthor

/integrate

@zhengyu123
Copy link
ContributorAuthor

Got approval and pushed

@openjdk
Copy link

openjdkbot commentedNov 5, 2021

Going to push as commit6c86a41.
Since your change was applied there have been 13 commits pushed to themaster branch:

  • e160532: 8272345: macos doesn't checkos::set_boot_path() result
  • 6d63a86: 8272114: Unused _last_state in osThread_windows
  • a384377: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • 9a2c123: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 0ab99ed: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • a834b58: 8269269: [macos11] SystemIconTest fails with ClassCastException
  • 23326d5: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • 00fed20: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows
  • 9f3c840: 8268361: Fix the infinite loop in next_line
  • 4003db8: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
  • ... and 3 more:https://git.openjdk.java.net/jdk17u/compare/a0899bfbe14af29f6e86a7792e2bf294bd508ba7...master

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot closed thisNov 5, 2021
@openjdkopenjdkbot added integratedPull request has been integrated and removed readyPull request is ready to be integrated rfrPull request is ready for review labelsNov 5, 2021
@openjdk
Copy link

openjdkbot commentedNov 5, 2021

@zhengyu123 Pushed as commit6c86a41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredintegratedPull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zhengyu123
[8]ページ先頭
©2009-2025 Movatter.jp