Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

8275145: file.encoding system property has an incorrect value on Windows#213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
naotoj wants to merge1 commit intoopenjdk:masterfromnaotoj:JDK-8275145-backport
Closed

8275145: file.encoding system property has an incorrect value on Windows#213

naotoj wants to merge1 commit intoopenjdk:masterfromnaotoj:JDK-8275145-backport

Conversation

@naotoj
Copy link
Member

@naotojnaotoj commentedOct 22, 2021•
edited by openjdkbot
Loading

This PR is for a backport of the subject fix to jdk17u. The fix for jdk18 was applied cleanly.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275145: file.encoding system property has an incorrect value on Windows⚠️ Issue is not open.

Reviewers

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/213/head:pull/213
$ git checkout pull/213

Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.java.net/jdk17u pull/213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 213

View PR using the GUI difftool:
$ git pr show -t 213

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/213.diff

@bridgekeeper
Copy link

👋 Welcome back naoto! A progress list of the required criteria for merging this PR intomaster will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

@openjdkopenjdkbot added the rfrPull request is ready for review labelOct 22, 2021
@mlbridge
Copy link

Webrevs

@openjdk
Copy link

openjdkbot commentedOct 22, 2021

@naotoj This change now passes allautomated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the fileCONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275145: file.encoding system property has an incorrect value on WindowsReviewed-by: iris

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to themaster branch:

  • 90273f3: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
  • 844d8bf: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • facbabb: 8270946: X509CertImpl.getFingerprint should not return the empty String

Please seethis link for an up-to-date comparison between the source branch of this pull request and themaster branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the/integrate command for further details.

➡️ To integrate this PR with the above commit message to themaster branch, type/integrate in a new comment.

@openjdkopenjdkbot added the readyPull request is ready to be integrated labelOct 22, 2021
@naotoj
Copy link
MemberAuthor

/integrate

@openjdk
Copy link

openjdkbot commentedOct 23, 2021

Going to push as commit031c033.
Since your change was applied there have been 3 commits pushed to themaster branch:

  • 90273f3: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
  • 844d8bf: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • facbabb: 8270946: X509CertImpl.getFingerprint should not return the empty String

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot closed thisOct 23, 2021
@openjdkopenjdkbot added integratedPull request has been integrated and removed readyPull request is ready to be integrated rfrPull request is ready for review labelsOct 23, 2021
@openjdk
Copy link

openjdkbot commentedOct 23, 2021

@naotoj Pushed as commit031c033.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@irisclarkirisclarkirisclark approved these changes

Assignees

No one assigned

Labels

integratedPull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naotoj@irisclark
[8]ページ先頭
©2009-2025 Movatter.jp