Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/jdk15u-devPublic archive

8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST#123

Closed
yan-too wants to merge1 commit intoopenjdk:masterfromyan-too:poststr

Conversation

@yan-too
Copy link
Collaborator

@yan-tooyan-too commentedOct 28, 2021
edited by openjdkbot
Loading

This useful fix should be ported here, too. Clean. All relevant tests pass.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

Reviewing

Usinggit

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/123/head:pull/123
$ git checkout pull/123

Update a local copy of the PR:
$ git checkout pull/123
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 123

View PR using the GUI difftool:
$ git pr show -t 123

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/123.diff

@bridgekeeper
Copy link

👋 Welcome back yan! A progress list of the required criteria for merging this PR intomaster will be added to the body of your pull request. There are additionalpull request commands available for use with this pull request.

@openjdkopenjdkbot changed the titleBackport 45ce06c9f3e9bee7d4bda313c38f0f0e8786a4db8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POSTOct 28, 2021
@openjdk
Copy link

openjdkbot commentedOct 28, 2021

This backport pull request has now been updated with issue from the originalcommit.

@openjdk
Copy link

openjdkbot commentedOct 28, 2021
edited
Loading

@yan-too This change now passes allautomated pre-integration checks.

After integration, the commit message for the final commit will be:

8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST

You can usepull request commands such as/summary,/contributor and/issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to themaster branch:

  • d38d207: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream

Please seethis link for an up-to-date comparison between the source branch of this pull request and themaster branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the/integrate command for further details.

➡️ To integrate this PR with the above commit message to themaster branch, type/integrate in a new comment.

@openjdkopenjdkbot added readyPull request is ready to be integrated rfrPull request is ready for review labelsOct 28, 2021
@yan-too
Copy link
CollaboratorAuthor

/integrate

@openjdk
Copy link

openjdkbot commentedOct 28, 2021

Going to push as commitca60952.
Since your change was applied there has been 1 commit pushed to themaster branch:

  • d38d207: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream

Your commit was automatically rebased without conflicts.

@openjdkopenjdkbot closed thisOct 28, 2021
@openjdkopenjdkbot added integratedPull request has been integrated and removed readyPull request is ready to be integrated rfrPull request is ready for review labelsOct 28, 2021
@openjdk
Copy link

openjdkbot commentedOct 28, 2021

@yan-too Pushed as commitca60952.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-tooyan-too deleted the poststr branchOctober 28, 2021 08:00
@mlbridge
Copy link

Webrevs

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

backportcleanintegratedPull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yan-too

[8]ページ先頭

©2009-2025 Movatter.jp