McCarthy was born inCape Town and grew up inHanover Park in theCape Flats,[6] an area notorious for its high unemployment rate and gang violence. He is the son of Dudley and Dora McCarthy and has two brothers and a sister.[7] His older brother isJerome McCarthy, a former professional footballer who played forKaizer Chiefs andManning Rangers, among other clubs, while his younger brother Mark played football atFranklin Pierce University in the United States.[7]
McCarthy began playing at a local side called Young Pirates, which was managed by his uncles. He then joined the youth structures of a local amateur club called Crusaders. At age 17, he was signed by first division clubSeven Stars.[8]
Playing forSeven Stars, the 18-year-old McCarthy scored 1 goal in 29 matches in the 1995–96 season, followed by another 12 goals in 20 matches, which earned him a transfer to Cape Town Spurs, which two years later merged with Seven Stars to form Dutch clubAjax'sfeeder team,Ajax Cape Town.
In 1997, after an impressive showing at theAfrican Youth Championship andFIFA World Youth Championship in Malaysia, he joined Ajax in theEredivisie, where he scored nine goals and was crowned champion in his first season. After a relatively successful1998–99 season, he was sold to Spanish sideCelta Vigo for a transfer fee reported to be over €6 million, at the time the most expensive transfer for a South African player.
Although regarded as one of the best African players at the time, McCarthy never established himself as a regular choice for Celta's manager,Víctor Fernández. After two poor seasons at theGalician club, he was loaned to strugglingPorto in the2001–02 season, where he soon rediscovered the form that took him to Europe.
At Porto, McCarthy played under the then newly appointed coachJosé Mourinho for an underperforming team that since winning theEuropean Cup in1987 had never been quite good enough to challenge for the top honours in Europe. However, that would soon change.
After representingBafana Bafana in the2002 African Nations Cup, where his national side was eliminated in the quarter-finals, McCarthy returned to Porto, where he became the main force behind the team's recovery. He helped them to third place in thePrimeira Liga and automatic qualification for theUEFA Cup by scoring an impressive 12 goals in 11 matches, but Porto's finances did not allow them to keep the player, despite the desire of both sides to continue.
In 2002–03, McCarthy therefore returned to Celta, where he spent much of his time on the substitutes' bench as a squad player as Porto captured theTaça de Portugal, the Portuguese League and theUEFA Cup. When Porto sold strikerHélder Postiga toTottenham Hotspur ahead of the 2003–04 season, Porto finally acquired McCarthy for a sum of €7.856 million,[9] (later re-sold part of the rights toGestiFute andFirst Portuguese Football Players Fund.)
On 25 July 2006, McCarthy flew out to England to undergo a medical and probable contract signing to join Blackburn Rovers.[10] Three days later, he signed a four-year contract with Blackburn for a £2.5 million transfer fee. The move meant that Rovers regularly fielded a side that contained two South African Internationals, the other beingAaron Mokoena who joined the club the year previous.
After a disappointing performance in the side's 3–0 defeat toPortsmouth, McCarthy found the net on his debut atEwood Park against Everton on 23 August 2006. McCarthy further endeared himself to Rovers fans, scoring a goal on his European debut for the club in a 2–2 againstRed Bull Salzburg in theUEFA Cup, and scoring another in the return leg. He finished second top scorer in the Premier League in2006–07 with 18 league goals, as well as 24 in all competitions.
The following season got off to a poor start for McCarthy when he was stretchered off in thePremier League opening day win againstMiddlesbrough. McCarthy was out of action for a few weeks and found first team opportunities limited, largely because the form of new striking arrivalRoque Santa Cruz. Despite being limited to largely substitute appearances, McCarthy did find the net 11 times in all competitions.
In the2008–09 season, McCarthy appeared to be out of favour with new managerPaul Ince, as the club's strike force was strengthened with the arrivals ofCarlos Villanueva andRobbie Fowler to join the already established Roque Santa Cruz,Jason Roberts andMatt Derbyshire. However, McCarthy answered these critics by scoring his first goal of the campaign – a 94th-minute equaliser in aPremier League match against Middlesbrough.
In all competitions for Blackburn, McCarthy scored 52 goals in 140 matches.
McCarthy completed a move to West Ham United for an undisclosed fee on transfer deadline day, 1 February 2010. He signed a two-and-a-half-year contract that was due to run until the summer of 2012. He made his Premier League debut for West Ham againstBurnley atTurf Moor in a 2–1 defeat on 6 February 2010, where he sustained an injury which would keep him out for six weeks.[11] In February 2011, having played just 326 minutes of football, making only three starts and failing to score any goals for West Ham, McCarthy was omitted from West Ham's 25-man squad for the remainder of the2010–11 season. He was also offered a £1 million pay-off in exchange for terminating his contract prematurely.[12][13] In April 2011, McCarthy left West Ham by mutual agreement after the parties agreed to terminate his contract.[14] He made only two Premier League starts and fourteen appearances in all competitions scoring no goals.[15]
After leaving West Ham, McCarthy trained with former club Ajax Cape Town during theABSA Premier League off-season. On 2 August,Orlando Pirates confirmed the signing of McCarthy on a two-year deal, ending his 14-year spell in Europe. On signing, McCarthy said, "I'm thrilled and delighted and hope I can show my appreciation by coming in and playing good football and hope to score as many goals as possible to put the team where they belong."[16] McCarthy began the season by scoring on debut and vowed to score more goals.
McCarthy scored two goals in the final half-hour to help the Pirates defeat theGolden Arrows 4–2 on 19 May 2012 to retain theirPremier League title.[17] He finished his successful season with ten league goals, ending the campaign as the fourth leading goal-scorer in the Premier League, helping the club secure their second successive treble. Having already won a league championship with Ajax in the Netherlands as well with Porto both domestically and in Europe, McCarthy would make football history by winning the league championship with Orlando Pirates in South Africa. This meant McCarthy was the first South African footballer to win three league titles with three different football clubs on two different continents.[18]
McCarthy, who is affectionately known as "Big Brother" by the Orlando Pirates faithful, was handed a red card for dissent in the MTN 8 secondleg semi-final played on 25 August 2012 after he chargedFranklin Cale after a reckless challenge onDaine Klate. This incident lead to protesting fans whom, in their view, Cale was equally guilty in the incident and should have also been shown red. McCarthy announced his retirement from professional football on 6 June 2013, aged 35.[19]
On 13 July 2014, McCarthy made a guest appearance for Scottish Lowland league clubWhitehill Welfare in a pre-season friendly against aHamilton Academical XI, scoring in the 14th minute and providing an assist for Whitehill Welfare player Kerr Dodds to score in the 20th minute.[20][21] McCarthy has a connection with the club through one of the Whitehill players, John Hall.[22]
McCarthy made his full international debut forSouth Africa in a friendly against theNetherlands on 4 June 1997.
Along with veteranEgyptian strikerHossam Hassan, McCarthy was the joint top scorer in the1998 African Cup of Nations in Burkina Faso with seven goals, including four in 13 minutes againstNamibia. In addition, he was named Player of the Tournament.
The1998 FIFA World Cup in France was the first time South Africa's national football team had reached the later stages of the competition, and McCarthy was one of their key players. After a 3–0 defeat against eventual championsFrance, South Africa played their second match againstDenmark. Trailing since the 13th minute, McCarthy tied the game at 1–1 in the 52nd minute and gave South Africa a chance for qualification after a 1–1 draw. However, the third match also ended in a draw, againstSaudi Arabia, which left the South Africans in third place and eliminated from the competition.
The2002 World Cup saw history repeating for the South Africans. After a 2–2 draw againstParaguay and a 1–0 victory overSlovenia, McCarthy's 30th-minute equaliser in the last match againstSpain was not enough, as South Africa eventually lost 3–2 and finished with another third place in the group stage.
There was often conflict over McCarthy's lack of participation in national team matches (whose interests often collide with his club's) and he actually retired from international matches after the 2002 World Cup. However, he returned to the national team in 2004 and eventually set the record for most international goals for South Africa; McCarthy's strike in the second half of a 3–0 win against Paraguay in a 2008 friendly eclipsed the previous record of 29 goals held byShaun Bartlett.
Prior to the2010 World Cup, held in South Africa, McCarthy announced his support for the Gun-Free World Cup campaign being run by International Action Network on Small Arms. He said, "This World Cup will be the biggest in football history and the fact that it is taking place in South Africa is a chance for us to show the world everything that is good about our country. It's great that guns will be banned from stadiums – it's going to be a fantastic party, and guns have no place in that."[23] After struggling with his fitness and facing criticism in his nation for being overweight, McCarthy was omitted from the final South African 23-man squad for the 2010 World Cup, which was announced on 1 June 2010.[24]
Living inEdinburgh since 2013, McCarthy confirmed in April 2015, that he had joined the coaching staff ofAlan Stubbs at Scottish clubHibernian.[25] Stubbs had invited McCarthy so he could just learn the coaching side of things. McCarthy knew Stubbs back from their playing days when McCarthy was atBlackburn Rovers and Stubbs was atEverton. McCarthy said, that he was going to help out with the U20s, and assisting with the first team.
In February 2015, he did a short internship atSint-Truidense underYannick Ferrera. On 8 September 2015, McCarthy was appointed assistant manager to managerChris O'Loughlin, who replacedYannick Ferrera.[26] Working his way through the different tiers of the UEFA Coaching Badges system, McCarthy met O'Loughlin.
On 20 April 2016, McCarthy stopped working with Sint-Truiden for personal reasons, after it was previously announced that his contract was not renewed.[27]
On 13 June 2017, McCarthy was unveiled as the newCape Town City head coach,[28] replacingEric Tinkler, who moved to manageSuperSport United. McCarthy would complete hisUEFA Pro License while coaching City, and would win his first silverware as a coach in 2018 when he guided City to theMTN 8 cup.[29] On 4 November 2019, McCarthy was dismissed as head coach of Cape Town City after just two wins in 18 games.
On 14 December 2020, McCarthy was unveiled as the newAmaZulu head coach, replacingAyanda Dlamini, who stepped down from the position on 7 December 2020. He took the club to a second-place finish in theDStv Premiership, a record high for AmaZulu in the modern era of the game in South Africa. As a result, AmaZulu qualified for the preliminary rounds of the2021–22 CAF Champions League. McCarthy led AmaZulu to the group stages of the 2021–22 CAF Champions League in their debut season before exiting the competition. McCarthy and AmaZulu parted company on 25 March 2022.[30]
On 30 July 2022, McCarthy was appointed as a first-team coach atManchester United.[31] Benni McCarthy's contract with Manchester United ended on27 June 2024. McCarthy chose not to renew his two-year contract so he could return to being a head coach.
On Monday, 3rd March, 2025, Benni was unveiled as Kenya Football (men) team Head Coach[32][33] in an event graced by Kenya Olympic Committee President,Paul Tergat, FKF president Hussein Mohammed, his deputyMcDonald Mariga and Odibets GM Dedan M.[34][35][36]
In 2004, McCarthy married Maria Santos from Spain. They have three daughters together: Minna, Mya and Allegra. In 2007, they separated.[37] In May 2014, McCarthy married Scottish model Stacey Munro. Together, they have one daughter, Lima Rose, born 2012[38] and one son, Lio Romero, born in 2019.[39]
In 1998, McCarthy collaborated with South Africankwaito music groupTKZee in "Shibobo". The song released in the run-up to the 1998 World Cup in France samples greatly on "The Final Countdown" byEurope and features McCarthy rapping part of the lyrics. He also appears in thefootball-themed music video for the song. Sales of the single topped the 100,000 mark in just over a month in South Africa, making "Shibobo" the fastest and biggest selling CD single by TKZee or other South African recording artists. The song was also a hit in other African music charts. The song enjoyed a comeback in a re-release in 2010–11.