Movatterモバイル変換


[0]ホーム

URL:


Skip to content
DEV Community
Log in Create account

DEV Community

Yonatan Karp-Rudin
Yonatan Karp-Rudin

Posted on • Originally published atyonatankarp.com on

     

Kotlin Code Smell 12 - Ripple Effect

TL;DR: If small changes have a significant impact, you need to decouple your system.

Problems

  • Coupling

Solutions

  • Decouple.

  • Cover with tests.

  • Refactor and isolate what is changing.

  • Depend on interfaces.

Examples

  • Legacy Systems

Sample Code

Wrong

classTime(privatevalhour:Int,privatevalminute:Int,privatevalseconds:Int){funnow(){// call operating system}}// Adding a TimeZone will have a big Ripple Effect// Changing now() to consider timezone will also bring the effect
Enter fullscreen modeExit fullscreen mode

Right

// Removed now() since it is invalid without contextdata classTime(privatevalhour:Int,privatevalminute:Int,privatevalseconds:Int,privatevaltimezone:String)classRelativeClock(privatevaltimezone:String){funnow(){vallocalSystemTime=this.localSystemTime()vallocalSystemTimezone=this.localSystemTimezone()// Make some calculations to translate timezones...returnTime(...,timezone)}// ...}
Enter fullscreen modeExit fullscreen mode

Conclusion

There are multiple strategies to deal with legacy and coupled systems. It is essential to address this problem before it becomes unmanageable.


Stay updated with my latest thoughts and ideas by registering for mynewsletter. Connect with me onLinkedIn orTwitter. Let's stay connected and keep the conversation going!


More info

Credits

Top comments(0)

Subscribe
pic
Create template

Templates let you quickly answer FAQs or store snippets for re-use.

Dismiss

Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment'spermalink.

For further actions, you may consider blocking this person and/orreporting abuse

For new articles by me feel free to visit my blog at https://yonatankarp.com and sign to the newsletter list :)
  • Location
    Berlin, Germany
  • Education
    Reichman University
  • Work
    Senior Backend Engineer @ SumUp
  • Joined

More fromYonatan Karp-Rudin

DEV Community

We're a place where coders share, stay up-to-date and grow their careers.

Log in Create account

[8]ページ先頭

©2009-2025 Movatter.jp