Movatterモバイル変換


[0]ホーム

URL:


Skip to content
DEV Community
Log in Create account

DEV Community

Cover image for I need feedback on my first website
Ahmad Khalid
Ahmad Khalid

Posted on

     

I need feedback on my first website

Hello everyone. I hope you having a good day.
I'm Ahmad - 32 yo - from Egypt. I'm currently learning frontend web development and I've completed my first project:Single-page developer portfolio challenge on Frontend Mentor.
I'd be happy to get your feedback on it.
Thanks in advance.
Code:https://github.com/ahmadkdev/developer-portfolio
Live demo:https://devportfoliosp.netlify.app/
My solution page on Frontend Mentor:https://www.frontendmentor.io/solutions/responsive-developer-portfolio-website-using-modern-css-techniques-iFqDLAczRk

Top comments(96)

Subscribe
pic
Create template

Templates let you quickly answer FAQs or store snippets for re-use.

Dismiss
CollapseExpand
 
ctnkaan profile image
Çetin Kaan Taşkıngenç
I make computers go beep boop
  • Location
    Turkey, Izmir
  • Education
    Yaşar University
  • Pronouns
    he/him
  • Work
    MagiClick Digital
  • Joined
• Edited on• Edited

It looks quite good for your first project. One recommendation I could give you is to improve your git commit messages. I've seen you make commits like "updated css stuff". This is not a best practice. I used to do commits like these when I first started coding but if you do proper git commits you can show these projects to other developers/recruiters.

I recommend you to check out and use semantic commit messages in the future. You'll get used to it in no time. Keep on coding!

Semantic Git Commits

CollapseExpand
 
atinypixel profile image
Aziz Kaukawala
Naive Reader • Programmer • Freelancer
  • Location
    Surat, India
  • Education
    Engineering Dropout & Community Taught Programmer
  • Work
    Senior Software Developer at Araneux Systems
  • Joined

Thank you!

Even after 7+ years, I didn't followed any such commit conventions, recently since ~6 months came across this very semantic doc and started using that. Day and night difference between my commits and 10x more easier to generate work reports etc.

Such small tweaks do result into great outcomes.

Happy Coding.

Best of luck@ahmadkdev for the new journey.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thank you.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thanks for your feedback and recommendation. It's really helpful.

CollapseExpand
 
chasm profile image
Charles F. Munat
I work with pedagogies, teach, write curricula, coach, manage, mentor, consult, speak publicly, polemicize, and sometimes work as a full-stack web developer, architect, ontologist, and more.
  • Email
  • Location
    Wellington, New Zealand
  • Education
    B.S. Informatics, B.A. Linguistics
  • Pronouns
    it's not about me
  • Work
    Founder of CraftCode.dev, director at Paperhat, Ltd.
  • Joined

Outstanding. A remarkable effort.

Your thinking may align with mine. You can read more about mine at my website,Craft Code, if curious.

I am particularly impressed that you stuck to vanilla code and didn't rush to React or similar; that you managed 100% across the board on Lighthouse and zero errors on axe DevTools (at AAA WCAG 2.2, no less); and that your code, at first glance, appears to conform to semantic HTML and best practies.

You must have put a lot of thought into this.

So, wow! Welcome to coding! We need more like you. I hope you can maintain this "keep it simple" approach, not adding unnecessary frills or pointless dependencies (as at least one commenter has suggested), and using the built-in Web APIs fully. As Arthur Quiller-Couch said, "murder your darlings".

Will try to keep an eye on your work.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Can't thank you enough your comment really motivated me to put more effort, and more importantly I knew I'm on the right path. I like your methodologies and It's what I've wanted to achieve and was in doubt I might be wrong because I see over-complicated websites everywhere.
I'm so happy for knowing about your amazing ideas and for your valuable time ❤️

CollapseExpand
 
chasm profile image
Charles F. Munat
I work with pedagogies, teach, write curricula, coach, manage, mentor, consult, speak publicly, polemicize, and sometimes work as a full-stack web developer, architect, ontologist, and more.
  • Email
  • Location
    Wellington, New Zealand
  • Education
    B.S. Informatics, B.A. Linguistics
  • Pronouns
    it's not about me
  • Work
    Founder of CraftCode.dev, director at Paperhat, Ltd.
  • Joined

You're very welcome. Keep up the excellent work.

It does often astonish me how many devs seem to be unclear on the subject. The point of programming is tosimplify complex problems, breaking them down into simpler and simpler pieces until they can be easily understood and solved. Yet many devs seem to be obsessed withcomplicating everything they touch.

I tend to think it's a "boys and their toys" situation – and it is clearly a masculine trait – this love of "techy" solutions. I like tech, too, but I take the opposite approach: start as simple as possible and avoid adding anything not truly necessary: YAGNI.

If you have any questions, I'm happy to answer them. And happier still if there are things you can teach me!

Cheers!

Thread Thread
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

I totally agree with you.

I've also checked your linkedin profile and got overwhelmed by your great work and more importantly your good effect on people around you (I read the reviews section) I'm so happy to know about such a great person like you.

You inspired me a lot and I'm sure I'm going to learn a lot from you.

Thank you!

Thread Thread
 
chasm profile image
Charles F. Munat
I work with pedagogies, teach, write curricula, coach, manage, mentor, consult, speak publicly, polemicize, and sometimes work as a full-stack web developer, architect, ontologist, and more.
  • Email
  • Location
    Wellington, New Zealand
  • Education
    B.S. Informatics, B.A. Linguistics
  • Pronouns
    it's not about me
  • Work
    Founder of CraftCode.dev, director at Paperhat, Ltd.
  • Joined

You're very welcome. Now I'm blushing. Thanks.

CollapseExpand
 
nikl profile image
Nik L.
Helping devs market for free. Let's connect if we haven't yet!
  • Location
    San Francisco, US.
  • Education
    IIT[]
  • Work
    SaaS
  • Joined

Looks good, just a suggestion as a user, perhaps use_blank in hyperlinks to make it open in new tab. For example, a user is checking your portfolio section, and wants to see both code and deployed project at once, he/ she when clicks on any one link first, it is currently opening in same, to check other thing that person needs to go back, adding an additional unnecessary friction.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Good note. I forgot to add _blank I'll fix it. Thank you.

CollapseExpand
 
jennherrarte profile image
Jenn Herrarte
Software Engineer 💻 | Chapter Director @ Techqueria 🌮 | Building in JavaScript, TypeScript, Vue.js 🔨
  • Location
    Los Angeles
  • Pronouns
    She/Her
  • Joined

super clean! I don't think you need years of experience for each technology, but that's just my person opinion. I think you have a good eye for design.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Totally agree. I'm going to change it to something better when I utilize the website for myself. Thank you.

CollapseExpand
 
jennherrarte profile image
Jenn Herrarte
Software Engineer 💻 | Chapter Director @ Techqueria 🌮 | Building in JavaScript, TypeScript, Vue.js 🔨
  • Location
    Los Angeles
  • Pronouns
    She/Her
  • Joined

I was just reviewing from a job hunting perspective. I think there are better ways to showcase the technologies you work on daily on your resume vs your porfolio. You can pick anything up that you haven't worked with if it's similar to something you've worked with before and I think the rating system might make recruiters forget that because they're just focused on how proficient or not proficient you are. just my take but good job!

CollapseExpand
 
fjones profile image
FJones
  • Location
    Munich, Germany
  • Work
    Software Development Team Lead
  • Joined

Showing skill level (of some description) on a portfolio page is good (if kept current), and YoE beats self-assigned star ratings any day.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Actually I find the whole section pointless. For a front-end developer html and css etc is a must-have and no need to mention it. Would be better if it was something like responsive web design or accessibility etc proved e.g. lighthouse scores and wave/axe tools, and ofcourse users' feedback.

CollapseExpand
 
kedzior_io profile image
Artur Kedzior
Head of Engineering @ Fiz, Bilbayt, Green Stuff World & Indie Maker - creator of salarioo.com
  • Location
    Alicante, Spain
  • Joined

Ahlan!

Not bad for the first project!

  • I like the simplicity
  • I like the theme
  • consistent font sizes
  • good separation of sections

Would improve:

  • personally would drop the circle effect from both under the title and over the image
  • I would do logo = h1, intro text = h2, section titles = h3 (and smaller than h2).
  • project links with target blank
  • contact inputs would have them texboxes inputs not lines, they are barely visible

Very nice and keep up the good work!

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thanks for your detailed feedback.
I agree with you on the circle effect it's a bit odd on desktop. I also agree with you on contact inputs they need a better visibility.
I'll rethink heading levels.
again thanks for your valuable time and detailed feedback.

CollapseExpand
 
kedzior_io profile image
Artur Kedzior
Head of Engineering @ Fiz, Bilbayt, Green Stuff World & Indie Maker - creator of salarioo.com
  • Location
    Alicante, Spain
  • Joined

Good luck fellow developer!

CollapseExpand
 
fjones profile image
FJones
  • Location
    Munich, Germany
  • Work
    Software Development Team Lead
  • Joined

Interestingly, I think the circle effect works quite well on mobile. Had to switch to desktop to see what you meant - and there I agree, it looks odd.

CollapseExpand
 
arindam-sahoo profile image
Arindam Sahoo
Learner, Explorer, Day Dreamer by Day, Over Thinker at Night, Love To Travel but didn't travel since 2012
  • Location
    Kolkata
  • Education
    B.Tech CSE(AI & ML) from Narula Institute of Technology
  • Pronouns
    He/Him
  • Work
    Student || Coding Instructor || Technical Translator
  • Joined
• Edited on• Edited

It looks quite good, and impressive as a first project. Just wanted to let you know that the social icons lead to the homepages of the respective websites instead of your profile. Second, there are AI Image Resolution Enhancers to Enhance the Resolution of your Image, because currently because of increasing the size of the image, it got pixelated.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thanks for your feedback. It's a template page so I chose to put links to homepages of respective websites instead ofhref="#". Do you think it's a good choice?
And for the image getting pixelated It's also from the template but I'll try to improve it.

CollapseExpand
 
best_codes profile image
Best Codes
I love coding, 3D designing, and listening to music.I'm currently a fanatic about Rust, TypeScript, and Next.js.Christian, Coder, Creator

It would probably be better if the icons lead to your profile on each of those sites (e.g.,github.com/The-Best-Codes for me). It would engage users more and plus you might get followers on those places from your website. 😊
Also, I'm not sure if the contact form works… The website is awesome, and I completely understand if it is just a template, and functionality is coming soon. Keep up the good work!

Thread Thread
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

I'm going to utilize it for myself soon adding my social profiles and hook the contact form to a database. Thanks for your advices.

CollapseExpand
 
fjones profile image
FJones
  • Location
    Munich, Germany
  • Work
    Software Development Team Lead
  • Joined

Unless you plan to add profile links, I would recommend just omitting the social media links (and - personal preference - if there's fewer than three, don't use icon lists).

Thread Thread
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

I'm going to utilize it for myself soon adding my social profiles. Thanks for your advices.

CollapseExpand
 
renancferro profile image
Renan Ferro
Frontend Developer ❤️‍🔥 | Just learning, practicing, coding and letting a little bit of it spread out forever and ever ➿ Be brave enough to be bad at something new!
  • Location
    Brazil
  • Education
    Bachelor's Degree in Information Systems
  • Work
    Frontend Developer
  • Joined

Nice work@ahmadkdev , I liked it!

For a second stage, I think you could add some things, like:

  • Animations
  • Accessibility

I think these two things can make your website cooler!

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thank you. I totally agree with you and for accessibility I already did the bare minimum but I intend to extend it by testing it manually e.g. using just the keyboard. It's on my ToDo list.

CollapseExpand
 
best_codes profile image
Best Codes
I love coding, 3D designing, and listening to music.I'm currently a fanatic about Rust, TypeScript, and Next.js.Christian, Coder, Creator

Your website looks great! If you need any ideas, here's mine:
the-best-codes.github.io/?dev.to

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thank you. Your website looks great too.

CollapseExpand
 
ranjancse profile image
Ranjan Dailata
A Professional based out of India specialized in handling AI-powered automations. Contact me at ranjancse@gmail.com, LinkedIn - https://www.linkedin.com/in/ranjan-dailata/

Looks amazing.

One advice, please try to follow the UI/UX design practices or guidelines. You may follow -semantic-ui.com/.

Also, please update your live demo with the valid social links. I understand that you have created it for the demo purposes, however it's always good to have a realistic data so folks can contact you :)

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thanks for your feedback. I'm still discovering UI/UX design practices and guidelines. I'm going to utilize the website soon for myself and add my details.

CollapseExpand
 
adhurimgervalla profile image
Adhurim Gervalla
  • Joined
• Edited on• Edited

very cool website.
I would try to integrate some elegant animations. Even just adding at least transitions to the hover effects already helps. I would also make the projects link tags "_blank". Otherwise good job.

CollapseExpand
 
ahmadkdev profile image
Ahmad Khalid
🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

Thank you. Two good points on my ToDo list.

Some comments may only be visible to logged-in visitors.Sign in to view all comments. Some comments have been hidden by the post's author -find out more

Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment'spermalink.

For further actions, you may consider blocking this person and/orreporting abuse

🌱 I'm learning front-end web development and I'd love to share my learning journey with you! I'll publish my projects, notes and resources I find useful. ✨
  • Location
    Egypt
  • Pronouns
    He/Him
  • Joined

More fromAhmad Khalid

DEV Community

We're a place where coders share, stay up-to-date and grow their careers.

Log in Create account

[8]ページ先頭

©2009-2025 Movatter.jp