Accepted

None of yourQUEUE_* functions validate their input arguments before using them.NULL pointers will be a problem, particularly ...

The reason why there is no async API for a dictionary is, that all operations on a dictionary are so fast, that there is no need for asynchronicity.For concurrent scenarios there is the thread safe ...

Accepted

Welcome to code review and thanks for sharing your code.When writing UnitTests keep in mind that they are documentation. Test code has less restrictions for identifier names.This means that method ...

Accepted

Here are a few of the high- and low-level ideas:too many comments. Remember, comments tend to age and outdate, they need to be maintained as the code changes. And, if they are over-used, they hurt ...

Accepted

Q&A Is the code readable?ExactlyOne states very clearly what the method is supposed to do.source is null seems odd to me ...

Accepted

1. BugThe code in the post does not work!>>> index_of('abba', 'bba')>>> # expected 1 but got NoneRead on to see how you could have ...

Yourmain is a classic arrow anti-pattern. You can use guard clauses to make the code flat and easier to understand.Bare excepts are normally not a good idea. Why ...

standard libraries are, umm, standard...

This looks really nice! Here we go: Is the API well thought and idiomatic?Mostly. For a library as simplistic as this, you probably want to avoid creating a special enum when returning ...

Threading DesignYour implementation has a very intrusive lock for all read and write operations, using theSemaphoreSlim with max concurrency 1. ...

Accepted

Python normally promotes duck typing, yours is more statically typed.You may want to useyield, as your current code possibly uses more memory than needed.You can ...

Accepted

Data typesWhy not use a simplepoint struct instead ofstd::pair<int, int>? It doesn't have to do anything, just a simple ...

mhmmm... I'm not so sure about this implementation. @dfhwze's points are valid but still, I find it's overengineered.I prefer chaining these two alraedy available extensions that can do all ...

It's pretty hard to break something that uses a global lock around everything. So this seems pretty thread-safe. But that doesn't answer the question of why you'd want to use this. Asynchronous ...

Accepted

BinarySearchTheBinarySearch class should bepublic since it contains utility methods that are generally useful. To do this, ...

Accepted

A search for "python sort unit test order in method definition order" got me here, and the documentation isn't particularly useful either ("Function" it says, what is it passed, what is it expected to ...

Accepted

I would not return IStopwatch from Start/Stop/etc. This IStopwatch is not an immutable Value Object, like String for example: it would be easier to set expectations by having just this:...

Accepted

I've come back to this question about 4 or 5 times since it was originally posted, started writing up an answer, started doubting my alternative implementation, scrapped it, and then come back about a ...

Accepted

Reading Material .. any reading material about searching algorithms on treesThese are the most common tree walkers:Breadth-First SearchDepth-First SearchReviewThere is a bug with IsRoot. Also,...

This is for dfhwze as per comment:...

Accepted

I'm not a C++ developer, and can't comment on the details of the code. But I can comment on the test cases and the general style of the code.A good test should be enough to recreate the code from ...

When you have queued a pointer you can never get that pointer again. It is also very difficult to know when that pointer has been dequeued. This is a recipe for leaks. Instead returning the pointer ...

...

Accepted

Statement-like macros should normally be wrapped indo...while(0). They should also avoid multiple expansion of arguments. So ...

Accepted

If you modify theAsyncDictionary while enumerating its keys/values it throwsInvalidOperationException (if the backing ...

Mocking system calls, especially those with side effects (mkdir()), is difficult and error prone.I would rather use a temporary directory for test purposes. This ...

Accepted

I'm no professional when it comes to testing. But it looks like your code is a perfect example on non-test friendly code. And is why SRP, single responsibility principle is such a big thing.From my ...