You should use theList#toArray method, you want to use the generic method, so not the one returningObject[], for this to work you need to supply an array of the correct size, such that it can store the data there.

List<String> list = ...;String[] = list.toArray(new String[list.size()]);

Note that the arrayneed not be the same size, there are two cases to consider:

• Ifarray.length < list.size(), then it will create a new array and return that one.
• Else, it will put the data in the input array.

Two small comments:

Spacing:

You put every single instruction on a separate linewith additional newlines around. IMO that is completely overkill and reduces the readability of code. It's harder to subdivide code into logical sections when you read.

But aside from that, you seem to mostly ignore theSpacebar, which cramps your operators together and makes them hard to find in between all the letters.

String[] temp = new String[arguments.length + 1];for(int i=0; i<arguments.length; i++)    temp[i] = arguments[i];temp[arguments.length] = arg;arguments = temp;return arguments;

compare your code [^] with how I would have written the same instructions and decide for yourself which is better:

String[] temp = new String[arguments.length +1];for (int i = 0; i < arguments.length; i++) {    temp[i] = arguments[i];}temp[arguments.length] = arg;arguments = temp;return arguments;

Clearing:

Injava there isabsolutely no need to purge references, the garbage collector will do that for you:

temp = null;

isutterly useless and should be removed.

• 1
  \$\begingroup\$Simply return temp after the arg is set and avoid the reassignment as well.\$\endgroup\$

  Robin

  – Robin

  2014-07-23 18:47:08 +00:00

  CommentedJul 23, 2014 at 18:47

you can make it more efficient with System.arraycopy

public static String[] addArgument(String[] arguments, String arg) {    String[] temp = new String[arguments.length + 1];    System.arraycopy(arguments, 0, temp, 0, arguments.length);    temp[arguments.length] = arg;    return temp;}

(also removing some unnecessary assignments). Moving it to a list, doing your modifcations and back can make it more efficient if doing a lot of operations on it since this is expensive if the arguments array is of any size. Best if only consider arrays for more immutable things and use collection's data structures for anything more complex unless theres a really good reason.

Use a list for building your array, then convert your list into an array before you return it from your function. =)

• java
• array