I wrote my implementation to Queue Linked List based. And I need a review for it to improve it and improve my coding skill. I also will put this implementation on my GitHub account.

//======================================================// Author      : Omar_Hafez// Created     : 30 July 2022 (Saturday)  8:02:31 AM//======================================================#include <iostream>#include <memory>template <class T>class Queue {        private:        struct Node {            T value;            std::shared_ptr<Node> next;            Node (T data, std::shared_ptr<Node> ptr) : value(data), next(ptr) {}        };                int size_value = 0;        std::shared_ptr<Node> back;        std::shared_ptr<Node> front;    public:        enum QueueOpStatus { FailedQueueEmpty = -1, FailedQueueFull = -2, OK = 1 };        //  this constructor is to keep the consistency with the array based implementation        Queue(int MAX_SIZE = 1000000) {}        QueueOpStatus push(T const& t) {            if(full()) return FailedQueueFull;            if(front) {                back->next = std::make_shared<Node>(t, nullptr);                back = back->next;            } else {                front = std::make_shared<Node>(t, nullptr);                back = front;            }            size_value++;            return OK;        }        QueueOpStatus pop() {            if (empty()) return FailedQueueEmpty;            front = front->next;            size_value--;            return OK;        }        bool empty() const { return size_value == 0; }        bool full() const { return 0; }        int size() const { return size_value; }        T top() const {             if(empty()) {                throw "Queue is empty";            }            return front->value;         }        void clear() {            while(!empty()) {                pop();            }        }};

1 Answer1

Start asking to get answers

Find the answer to your question by asking.

Explore related questions

See similar questions with these tags.