This is without optimizations, but the errors that you describe seem to be in how you are getting the data.

Based on your lists within list and the error message you are getting , try something like this:

etchVector = list.Where(vio => excelViolations.Any(currVio => vio.VioID.Formatted.Equals(currVio.VioID.ToString())                        && vio.RuleType.Formatted.Equals(currVio.RuleType)                        && vio.VioType.Formatted.Equals(currVio.VioType)                        && vio.Bows.Any(bw => bw.XCoordinate.Equals(currVio.XCoordinate))                        && vio.Bows.Any(bw1 => bw1.YCoordinate.Equals(currVio.YCoordinate)))).SelectMany(vi => vi.EtchVects).ToList();

• \$\begingroup\$that works, interesting. that fixed my data problem, now onto the optimization. thanks\$\endgroup\$

  Chris Hamilton

  – Chris Hamilton

  2013-05-13 20:26:05 +00:00

  CommentedMay 13, 2013 at 20:26

You can definitely optimize this query. Iflist has M items andexcelViolations has N items, the query will iterateexcelViolations M*5N times.

It is possible to reduce this to M*N iterations by consumingexcelViolations only once per item inlist. You can do this with a subquery onexcelViolations that checks all five conditions for eachexcelVio, then ORs each of the five conditions across allexcelVio instances.

If that is not clear, hopefully this walkthrough is:

from vio in list// Perform all five checks for each excelViolet checks = excelViolations    .Select(excelVio => new    {        HasVioID = vio.VioID.Formatted.Equals(excelVio.VioID.ToString()),        HasRuleType = vio.RuleType.Formatted.Equals(excelVio.RuleType),        HasVioType = vio.VioType.Formatted.Equals(excelVio.VioType),        HasXCoordinate = vio.EtchVects.Any(x => x.XCoordinate.Equals(excelVio.XCoordinate)),        HasYCoordinate = vio.EtchVects.Any(y => y.YCoordinate.Equals(excelVio.YCoordinate))    })// From left to right, OR each of the five results (equivalent to .Any)    .Aggregate((left, right) => new    {        HasVioID = (left.HasVioID || right.HasVioID),        HasRuleType = (left.HasRuleType || right.HasRuleType),        HasVioType = (left.HasVioType || right.HasVioType),        HasXCoordinate = (left.HasXCoordinate || right.HasXCoordinate),        HasYCoordinate = (left.HasYCoordinate || right.HasYCoordinate)    })// Filter to only those that pass every checkwhere checks.HasVioID    && checks.HasRuleType    && checks.HasVioType    && checks.HasXCoordinate    && checks.HasYCoordinate// Same projectionselect new EtchVectorShapes{    VioID = Convert.ToInt32(vio.EtchVects.Select(x => x.VioID)),    ObjectType = vio.EtchVects.Select(x => x.ObjectType).ToString(),    XCoordinate = Convert.ToDouble(vio.EtchVects.Select(x => x.XCoordinate)),    YCoordinate = Convert.ToDouble(vio.EtchVects.Select(x => x.YCoordinate)),    Layer = vio.EtchVects.Select(x => x.Layer).ToString()};

The underlying problem is that vio.EtchVects isIEnumerable<T>, and LINQIEnumerable<T>.Select functions still returnIEnumerable<T>. YourConvert.ToX functions are expecting scalar values.

For simplicity, I will build from @Bryan Watts' answer, starting only with the select statement.

If you want only the EtchVectors as a flat list, you can do the following:

from vect in vio.EtchVectsselect new EtchVectorShapes{    VioID = Convert.ToInt32(vect.VioID),    ObjectType = vect.ObjectType.ToString(),    XCoordinate = Convert.ToDouble(vect.XCoordinate),    YCoordinate = Convert.ToDouble(vect.YCoordinate),    Layer = vect.Layer.ToString()};

If you want them to retain the same organizational hierarchy they started with, you can do something similar to the following:

select new EtchVectorShapes{    Shapes = from vect in vio.EtchVects             select new EtchVectorShape             {                 VioID = Convert.ToInt32(vect.VioID),                 ObjectType = vect.ObjectType.ToString(),                 XCoordinate = Convert.ToDouble(vect.XCoordinate),                 YCoordinate = Convert.ToDouble(vect.YCoordinate),                 Layer = vect.Layer.ToString()             }};

If you only want one of the vectors from each vio, you could use one of the scalar LINQ functions (e.g., First or Last) or one of the aggregate functions (e.g., Max or Sum):

let vect = vio.EtchVects.First ()select new EtchVectorShapes{    VioID = Convert.ToInt32(vect.VioID),    ObjectType = vect.ObjectType.ToString(),    XCoordinate = Convert.ToDouble(vect.XCoordinate),    YCoordinate = Convert.ToDouble(vect.YCoordinate),    Layer = vect.Layer.ToString()};

• \$\begingroup\$I still get errors as mentioned above with all the conversions like Convert.ToInt32 etc.. VioID = Convert.ToInt32(vect.VioID), ObjectType = vect.ObjectType.ToString(), XCoordinate = Convert.ToDouble(vect.XCoordinate), YCoordinate = Convert.ToDouble(vect.YCoordinate), Layer = vect.Layer.ToString()\$\endgroup\$

  Chris Hamilton

  – Chris Hamilton

  2013-05-13 20:25:07 +00:00

  CommentedMay 13, 2013 at 20:25

• c#
• performance
• linq