Your code's quite good. I'd however change it in the following ways:

1. Move the creation of the lits out of thebuble_sort.
2. Remove theprints frombuble_sort.
3. FollowPEP8.
4. Changefor i in range(...) towhile True:.
5. Use better variables.num_list toarray could do.
6. Usestr.format, rather than string addition.
7. Change the creation ofnum_list to use a list comprehension.

def bubble_sort(array):    while True:        swapped = False        for j in range(len(array)-1):            if array[j] > array[j+1]:                array[j], array[j+1] = array[j+1], array[j]                swapped = True        if not swapped:            breakif __name__ == '__main__':    amount = input("How many numbers you would like to sort:")    array = [        int(input("Enter {} number:".format(i)))        for i in range(int(amount))    ]    print("The values input are as follows: {}".format(array))    bubble_sort(array)    print("The sorted list is: {}".format(array))

• 6
  \$\begingroup\$I agree with everything except renamingnum_list toarray, since it is a list, not an array.numbers would probably be better, since it explains what it contains, and implies that it is a sequence without stating a concrete type.\$\endgroup\$

  Raimund Krämer

  – Raimund Krämer

  2018-04-25 13:43:48 +00:00

  CommentedApr 25, 2018 at 13:43
• \$\begingroup\$@RaimundKrämer You could uselist however that shadowslist. They're also IIRC arrays with list interfaces, so it's simpler to call it a list. Also we're only using it for it's array interface. But yeahnumbers could work.\$\endgroup\$

  Peilonrayz

  – Peilonrayz♦

  2018-04-25 13:45:10 +00:00

  CommentedApr 25, 2018 at 13:45

The IO code is mixed with the logic code. I separated them. Also, I made a few other changes including removing useless comments (the code should speak for itself, your comments don't add much; if you need comments, that probably means you should simplify your code). I also converted the numbers as soon as they are input.

def bubble_sort(num_list):    for i in range(len(num_list)-1):        swapped = False                for j in range(len(num_list) - 1):            if num_list[j] > num_list[j+1]:                num_list[j], num_list[j+1] = num_list[j+1], num_list[j]                swapped = True                if not swapped:            returndef main():    num_list = []    num_items = int(input("How many numbers you would like to sort:"))        for i in range(num_items):        num_list.append(int(input("Enter " + str(i + 1) + "st number:")))        bubble_sort(num_list)    print("The sorted list is:")    print(num_list)if __name__ == '__main__':    main()

• python
• beginner
• python-3.x
• sorting