| commit | 645d4234a6753a73f0b0f2a1e591cb2460d5a00c | [log][tgz] |
|---|---|---|
| author | Dominic Battre <battre@chromium.org> | Fri Dec 04 16:14:10 2020 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 04 16:14:10 2020 |
| tree | e35129440f43170f54d658e45f8a678ac84ed01e | |
| parent | 2d3a3d1cbc95eeeea385120aea911b8ff4230d36[diff] |
Check deprecation of preferencesIt's a common mistake that developers just remove Register...Pref()calls for preferences they don't need anymore. If they do this, thepreference stays in the prefs files on disk for ever. A proper approachis to first ClearPref() the preference for some releases and then toremove the code.This CL introduces a presubmit warning if we detect that aRegister...Pref() call is removed from a non-unittest.Bug: 1153014Change-Id:If8f19933de039553ef47e0ddce12eb194df45ce1Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2560205Commit-Queue: Dominic Battré <battre@chromium.org>Reviewed-by: Jochen Eisinger <jochen@chromium.org>Reviewed-by: Gabriel Charette <gab@chromium.org>Reviewed-by: Dominic Battré <battre@chromium.org>Cr-Commit-Position: refs/heads/master@{#833730}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site ishttps://www.chromium.org.
Documentation in the source is rooted indocs/README.md.
Learn how toGet Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
