| commit | 74806a42cc605b715dc7692b37d57121f56f8827 | [log][tgz] |
|---|---|---|
| author | Tomasz Wiszkowski <ender@google.com> | Thu Jun 13 20:34:52 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 13 20:34:52 2024 |
| tree | b3719f1e4c64649ffde2dc7e410adf84312de26f | |
| parent | a43fccb53f24b8bd02102e92c2f9f1402a9d50ba[diff] |
Dispatch ENTER key presses after these are processed by IME.Recent change to process hardware keys ahead of IME fixed hardwarekeyboard handling with gboard, but broke ENTER key processing. We usethe ENTER key to initiate navigation, but if the hardware keyboardis not in use, the event does not show up in onKeyPreIme.This change introduces an exception for ENTER key handling, enablingIME to initiate navigation again.NOTE: we may want to eventually narrow down this entire handling tofocus only on the events we truly care about: DPAD, TAB, ENTER and"user started typing" for optimal results. This change is needed tocut the DEV branch.(cherry picked from commit 4148600de85a67667862bd78c8b8697926af6096)Change-Id:I30dfd50d7ca3c7a5e99c14df751ec0b9cc7cb0efFixed: b:346898512Bug: b:344930378Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5631254Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>Reviewed-by: Patrick Noland <pnoland@chromium.org>Auto-Submit: Tomasz Wiszkowski <ender@google.com>Commit-Queue: Tomasz Wiszkowski <ender@google.com>Cr-Original-Commit-Position: refs/heads/main@{#1314829}Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5631536Reviewed-by: Erhu Akpobaro <eakpobaro@google.com>Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>Auto-Submit: Erhu Akpobaro <eakpobaro@google.com>Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>Owners-Override: Erhu Akpobaro <eakpobaro@google.com>Cr-Commit-Position: refs/branch-heads/6537@{#4}Cr-Branched-From: b13b04ec4900d3dc0b9c63d53b7dbe3308f57d26-refs/heads/main@{#1314551}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site ishttps://www.chromium.org.
To check out the source code locally, don't usegit clone! Instead, followthe instructions on how to get the code.
Documentation in the source is rooted indocs/README.md.
Learn how toGet Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it athttps://crbug.com/new.
