| commit | cc77ea9bf7a2b3ec4440277e113f3cabe2c8643c | [log][tgz] |
|---|---|---|
| author | Omer Katz <omerkatz@chromium.org> | Mon Apr 26 10:23:28 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 26 10:23:28 2021 |
| tree | 6aca89d03d823d0973d24759175e5efa3ff24b58 | |
| parent | e3bdd782b84664c0db848aa87bc8d111e1e96c3c[diff] |
heap: Add presubmit check for includes from impl and v8_wrapperWith the upcoming Blink migration to the new Oilpan library in v8, wehave for each Oilpan header a version under heap/impl/ (the previousimplementation) and a version under heap/v8_wrapper/ (for the newlibrary).Each duplicate CL has a counterpart under heap/ that delegates betweenthe 2 versions according to build flags.Users of Oilpan should only include files from heap/, not heap/impl/ orheap/v8_wrapper/.Clangd sometimes adds includes automatically to code when needed. Clangduses the files under heap/impl/ (currently the ones used by default)which causes builds with the library to break.This CL adds a check that files outside of heap/ don't directly includefiles from heap/impl/ and heap/v8_wrapper/. This presubmit check wouldinform developers to use the heap/ counterpart.Bug: 1056170Change-Id:I9d67773b37995e3eadb8612ff44d5af503aaed91Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2848165Reviewed-by: Kentaro Hara <haraken@chromium.org>Commit-Queue: Omer Katz <omerkatz@chromium.org>Cr-Commit-Position: refs/heads/master@{#876101}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site ishttps://www.chromium.org.
To check out the source code locally, don't usegit clone! Instead, followthe instructions on how to get the code.
Documentation in the source is rooted indocs/README.md.
Learn how toGet Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
