commit | 533295e02a39f85a9e476c66bed10c7f0e785f43 | [log][tgz] |
---|---|---|
author | David Benjamin <davidben@chromium.org> | Mon Jul 01 22:01:14 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 01 22:01:14 2024 |
tree | 3e65824df62f5452909577cd54fdec3cec670d8d | |
parent | 85360c2f0bf9219f200c13db443d01eae745ffdf[diff] |
Revert "Promote most UBSan flags to the ASan configuration on non-Windows"This reverts commit 36c0df1671dccd3a8f76248d521c918e6c873afc.Reason for revert: It seems the combination of UBSan, ASan, and fuzzerinstrumentation makes browser tests run far too slow. (Or there's somedeeper error being suppressed that I can't figure out, but it seems tojust be slow.) I suspect we'll need to make UBSan into a separatebot.Original change's description:> Promote most UBSan flags to the ASan configuration on non-Windows>> This ratchets these in so we don't regress them. The alignment and null> checks are not yet clear, so keep them on the FYI configuration for now.> To avoid needing to introduce another set of builders, enable them on> the ASan builders.>> This does not enable on Windows yet because the bots are not yet> clear. First, -fsanitize=object-size will need to be suppressed due> tohttps://github.com/llvm/llvm-project/issues/31914. Beyond that,> there are some issues in>https://ci.chromium.org/ui/p/chromium/builders/try/win-asan/11240/overview> that I have not been able to diagnose yet.>> Bug: 40248746> Change-Id:I970266c9ea3eb6b8c911f1bec5e29fc6e0198d4a> Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5646784> Reviewed-by: Titouan Rigoudy <titouan@chromium.org>> Auto-Submit: David Benjamin <davidben@chromium.org>> Commit-Queue: Titouan Rigoudy <titouan@chromium.org>> Cr-Commit-Position: refs/heads/main@{#1319068}Bug: 40248746, 349978811Change-Id:I0803bc52fbd6f33da9a1f24a143458a1982305aeReviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5663719Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>Reviewed-by: Lei Zhang <thestig@chromium.org>Commit-Queue: Lei Zhang <thestig@chromium.org>Cr-Commit-Position: refs/heads/main@{#1321866}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site ishttps://www.chromium.org.
To check out the source code locally, don't usegit clone
! Instead, followthe instructions on how to get the code.
Documentation in the source is rooted indocs/README.md.
Learn how toGet Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it athttps://crbug.com/new.