| commit | 3b5e94fb296836fde5415658ebb3c55b0ece425a | [log][tgz] |
|---|---|---|
| author | Xiaohan Wang <xhwang@chromium.org> | Fri Jan 21 00:05:31 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 21 00:05:31 2022 |
| tree | be1a2deba99d5f78d9ca8ad53c763d6ce81f3c93 | |
| parent | cb2ac42a9edb2416ad23e49551a5513fd66afa67[diff] |
tools: Fix primary header marking in add_header.pyThis CL fixes a corner case which isn't handled correctly byadd_header.py. When there are two includes with the same filename but in different paths, the current script may choosethe wrong one as the primary header since it passed all thefuzzy testing.To fix it, we add a first pass to do exact matching. Sinceexact matching would work for most of the times, this changeshould also improve the performance of this script.Bug: 1234043Change-Id:I7036fd703c77159e7303cda71777bce97f0e4d4aReviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/3405134Reviewed-by: Daniel Cheng <dcheng@chromium.org>Auto-Submit: Xiaohan Wang <xhwang@chromium.org>Reviewed-by: Dirk Pranke <dpranke@google.com>Commit-Queue: Dirk Pranke <dpranke@google.com>Cr-Commit-Position: refs/heads/main@{#961684}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site ishttps://www.chromium.org.
To check out the source code locally, don't usegit clone! Instead, followthe instructions on how to get the code.
Documentation in the source is rooted indocs/README.md.
Learn how toGet Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it athttps://crbug.com/new.
