Message72589
| Author | amaury.forgeotdarc |
|---|
| Recipients | amaury.forgeotdarc, nnorwitz, pitrou |
|---|
| Date | 2008-09-05.13:08:31 |
|---|
| SpamBayes Score | 0.00035566706 |
|---|
| Marked as misclassified | No |
|---|
| Message-id | <1220620114.55.0.43308624926.issue3660@psf.upfronthosting.co.za> |
|---|
| In-reply-to | |
|---|
| Content |
|---|
Antoine, it seem that with encode-leak2.patch, the error path afterPyErr_WarnEx() leaks the value of "v".I rewrote the whole paragraph to make it more straightforward:- the normal case is tested first- all paths end with a "return", and no goto.- no need to test that PyBytes_FromStringAndSize returns a PyBytes...I find the code much easier to check in this form, but of course this isa subjective POV. |
| History |
|---|
| Date | User | Action | Args |
|---|
| 2008-09-05 13:08:34 | amaury.forgeotdarc | set | recipients: +amaury.forgeotdarc,nnorwitz,pitrou | | 2008-09-05 13:08:34 | amaury.forgeotdarc | set | messageid: <1220620114.55.0.43308624926.issue3660@psf.upfronthosting.co.za> | | 2008-09-05 13:08:33 | amaury.forgeotdarc | link | issue3660 messages | | 2008-09-05 13:08:33 | amaury.forgeotdarc | create | |
|