Message328613
| Author | taleinat |
|---|
| Recipients | cstratak, serhiy.storchaka, shivank98, taleinat, vstinner |
|---|
| Date | 2018-10-26.21:58:09 |
|---|
| SpamBayes Score | -1.0 |
|---|
| Marked as misclassified | Yes |
|---|
| Message-id | <1540591089.54.0.788709270274.issue35052@psf.upfronthosting.co.za> |
|---|
| In-reply-to | |
|---|
| Content |
|---|
Shivank, indeed it seems you're now in the right direction.A bit of clarification:* The test shouldn't test _clone_node() directly, since that is an internal function. Rather, the test code should be as near as possible to what a user of the minidom module would reasonably write.* Since this bug appears in two places, you'll likely need different tests for each of them. You should likely start with just one, and once you've successfully written a test for it and fixed it, move on to the other. (In the end, make each test+fix a separate commit in the PR.) |
|