Movatterモバイル変換

Message269958

➜

This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	berker.peksag, ned.deily, skrah, vstinner, xdegaye, yan12125
Date	2016-07-07.20:24:02
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1467923043.03.0.748968767253.issue27442@psf.upfronthosting.co.za>
In-reply-to

Content
+ @unittest.skipIf(sysconfig.get_config_var('ANDROID_API_LEVEL') == 0,+ "not an android platform")+ def test_is_android(self):+ # Use an heuristic, the shell on Android is at /system/bin/sh.+ proc = subprocess.run(['/system/bin/sh', '-c', 'echo OK'],+ stdout=subprocess.PIPE)+ self.assertIn(b'OK', proc.stdout)I dislike such functional test, it might fail and might need maintaince.I suggest to push the change without the unit test.

Content

+    @unittest.skipIf(sysconfig.get_config_var('ANDROID_API_LEVEL') == 0,+                         "not an android platform")+    def test_is_android(self):+        # Use an heuristic, the shell on Android is at /system/bin/sh.+        proc = subprocess.run(['/system/bin/sh', '-c', 'echo OK'],+                              stdout=subprocess.PIPE)+        self.assertIn(b'OK', proc.stdout)I dislike such functional test, it might fail and might need maintaince.I suggest to push the change without the unit test.

History
Date	User	Action	Args
2016-07-07 20:24:03	vstinner	set	recipients: +vstinner,ned.deily,skrah,xdegaye,berker.peksag,yan12125
2016-07-07 20:24:03	vstinner	set	messageid: <1467923043.03.0.748968767253.issue27442@psf.upfronthosting.co.za>
2016-07-07 20:24:03	vstinner	link	issue27442 messages
2016-07-07 20:24:02	vstinner	create

Supported byThe Python Software Foundation,
Powered byRoundup