Message249895
| Author | ncoghlan |
|---|
| Recipients | James Salter, brett.cannon, ebfortin, eric.snow, larry, ncoghlan, paul.moore, petr.viktorin, steve.dower, tim.golden, zach.ware |
|---|
| Date | 2015-09-05.05:37:54 |
|---|
| SpamBayes Score | -1.0 |
|---|
| Marked as misclassified | Yes |
|---|
| Message-id | <1441431474.8.0.466567343622.issue24748@psf.upfronthosting.co.za> |
|---|
| In-reply-to | |
|---|
| Content |
|---|
Huh, for some reason the Rietveld diff missed the changes to _testmultiphase.c that are in the patch file.The change looks good to me. The test adds a new "test.imp_dummy" module, imports that, and then ensures it can be replaced by using imp.load_dynamic to import "test.imp_dummy" from the _testmultiphase module instead.The functional change itself is isolated to imp.load_dynamic, so no other code paths will be affected. |
| History |
|---|
| Date | User | Action | Args |
|---|
| 2015-09-05 05:37:54 | ncoghlan | set | recipients: +ncoghlan,brett.cannon,paul.moore,larry,tim.golden,petr.viktorin,eric.snow,zach.ware,steve.dower,James Salter,ebfortin | | 2015-09-05 05:37:54 | ncoghlan | set | messageid: <1441431474.8.0.466567343622.issue24748@psf.upfronthosting.co.za> | | 2015-09-05 05:37:54 | ncoghlan | link | issue24748 messages | | 2015-09-05 05:37:54 | ncoghlan | create | |
| 
➜