Message208883
| Author | vajrasky |
|---|
| Recipients | larry, nadeem.vawda, serhiy.storchaka, vajrasky |
|---|
| Date | 2014-01-23.07:50:27 |
|---|
| SpamBayes Score | -1.0 |
|---|
| Marked as misclassified | Yes |
|---|
| Message-id | <1390463430.83.0.499391951747.issue20185@psf.upfronthosting.co.za> |
|---|
| In-reply-to | |
|---|
| Content |
|---|
Here is the patch for floatobject. I did not convert 2 sites. The first is the round method which clinic explicitly does not support. The second one is the new method. This is the snippet of new method:float_new(PyTypeObject *type, PyObject *args, PyObject *kwds){ PyObject *x = Py_False; /* Integer zero */ static char *kwlist[] = {"x", 0}; if (type != &PyFloat_Type) return float_subtype_new(type, args, kwds); /* Wimp out */ if (!PyArg_ParseTupleAndKeywords(args, kwds, "|O:float", kwlist, &x)) return NULL; /* If it's a string, but not a string subclass, use PyFloat_FromString. */ if (PyUnicode_CheckExact(x)) return PyFloat_FromString(x);....If I clinic this method, I could not put custom code before parsing arguments code anymore. This could affect the performance or may not be correct at all. |
| History |
|---|
| Date | User | Action | Args |
|---|
| 2014-01-23 07:50:31 | vajrasky | set | recipients: +vajrasky,larry,nadeem.vawda,serhiy.storchaka | | 2014-01-23 07:50:30 | vajrasky | set | messageid: <1390463430.83.0.499391951747.issue20185@psf.upfronthosting.co.za> | | 2014-01-23 07:50:30 | vajrasky | link | issue20185 messages | | 2014-01-23 07:50:30 | vajrasky | create | |
|