Message206717
| Author | maciej.szulik |
|---|
| Recipients | BreamoreBoy, Juarez.Bochi, Julian.Gindi, adam-collard, ajaksu2, alanvgreen, amaury.forgeotdarc, belopolsky, berker.peksag, cvrebert, guettli, jafo, josh-sf, maciej.szulik, mark.dickinson, petre, sonderblade, tiktuk, vajrasky |
|---|
| Date | 2013-12-20.23:28:14 |
|---|
| SpamBayes Score | -1.0 |
|---|
| Marked as misclassified | Yes |
|---|
| Message-id | <1387582099.96.0.468562291661.issue1100942@psf.upfronthosting.co.za> |
|---|
| In-reply-to | |
|---|
| Content |
|---|
I'm attaching merged and fixed patch (issue1100942_full.patch). Though during testing I found one issue with the patch: during checking for time part in date class I'm using (in _datetimemodule.c->date_strptime) DATE_GET_HOUR etc, but when given time parts are 0's then the test fails. Should I leave the patch as is, because possibility for 0's is very low or should I check the format string for time parts existence? Any further advice is appreciated. |
| History |
|---|
| Date | User | Action | Args |
|---|
| 2013-12-20 23:28:20 | maciej.szulik | set | recipients: +maciej.szulik,jafo,guettli,amaury.forgeotdarc,mark.dickinson,belopolsky,sonderblade,alanvgreen,ajaksu2,josh-sf,cvrebert,tiktuk,adam-collard,BreamoreBoy,berker.peksag,Juarez.Bochi,petre,vajrasky,Julian.Gindi | | 2013-12-20 23:28:19 | maciej.szulik | set | messageid: <1387582099.96.0.468562291661.issue1100942@psf.upfronthosting.co.za> | | 2013-12-20 23:28:19 | maciej.szulik | link | issue1100942 messages | | 2013-12-20 23:28:19 | maciej.szulik | create | |
| 
➜