➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2019-09-15 07:29 byserhiy.storchaka, last changed2022-04-11 14:59 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 16155 | merged | serhiy.storchaka,2019-09-15 07:31 | |
| PR 16193 | merged | miss-islington,2019-09-16 17:15 | |
| PR 16194 | merged | miss-islington,2019-09-16 17:15 | |
| PR 16215 | merged | serhiy.storchaka,2019-09-17 06:13 | |
| Messages (5) | |||
|---|---|---|---|
| msg352465 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2019-09-15 07:29 | |
There is a memory leak in comparison of sqlite.Row objects when row descriptors are different. There were not tests for this case.Also, the code compares the result of PyObject_RichCompare() with Py_True and Py_False. It is better to avoid such code, because technically PyObject_RichCompare() can return an arbitrary value, although in this particular case description can only be tuple or None (or NULL, but this is other issue).Also, there is a test for inequality of hash codes. Since hashes depend on hashes of strings, they value is random, and there is a small chance of failure. Hashes should not be tested for inequality. | |||
| msg352558 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2019-09-16 17:15 | |
New changeset8debfa50407107ff2329d01081cdc12d359f1d12 by Serhiy Storchaka in branch 'master':bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155)https://github.com/python/cpython/commit/8debfa50407107ff2329d01081cdc12d359f1d12 | |||
| msg352601 -(view) | Author: miss-islington (miss-islington) | Date: 2019-09-17 06:14 | |
New changesetf04299d978793be33828dc4d5f46e9b54c81a0a2 by Miss Islington (bot) in branch '3.8':bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155)https://github.com/python/cpython/commit/f04299d978793be33828dc4d5f46e9b54c81a0a2 | |||
| msg352602 -(view) | Author: miss-islington (miss-islington) | Date: 2019-09-17 06:14 | |
New changeset4ac1be28281d8961e71b13623c3671245c125760 by Miss Islington (bot) in branch '3.7':bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155)https://github.com/python/cpython/commit/4ac1be28281d8961e71b13623c3671245c125760 | |||
| msg352614 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2019-09-17 06:56 | |
New changesetbe257bcad12b1d72a2c2a8199d2291ae22bccf78 by Serhiy Storchaka in branch '2.7':[2.7]bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155). (GH-16215)https://github.com/python/cpython/commit/be257bcad12b1d72a2c2a8199d2291ae22bccf78 | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:20 | admin | set | github: 82356 |
| 2019-09-17 06:56:48 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-09-17 06:56:30 | serhiy.storchaka | set | messages: +msg352614 |
| 2019-09-17 06:14:32 | miss-islington | set | messages: +msg352602 |
| 2019-09-17 06:14:23 | miss-islington | set | nosy: +miss-islington messages: +msg352601 |
| 2019-09-17 06:13:45 | serhiy.storchaka | set | pull_requests: +pull_request15816 |
| 2019-09-16 17:15:37 | miss-islington | set | pull_requests: +pull_request15800 |
| 2019-09-16 17:15:30 | miss-islington | set | pull_requests: +pull_request15799 |
| 2019-09-16 17:15:22 | serhiy.storchaka | set | messages: +msg352558 |
| 2019-09-15 07:31:34 | serhiy.storchaka | set | keywords: +patch stage: patch review pull_requests: +pull_request15765 |
| 2019-09-15 07:29:07 | serhiy.storchaka | create | |