
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2019-06-06 16:21 bytaleinat, last changed2022-04-11 14:59 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 13869 | merged | taleinat,2019-06-06 16:26 | |
| PR 13878 | merged | miss-islington,2019-06-07 05:55 | |
| PR 13879 | merged | miss-islington,2019-06-07 05:55 | |
| PR 13880 | merged | taleinat,2019-06-07 06:08 | |
| Messages (9) | |||
|---|---|---|---|
| msg344831 -(view) | Author: Tal Einat (taleinat)*![]() | Date: 2019-06-06 16:21 | |
This issue was brought up by Irv Kalb on the idle-dev mailing list.I haven't been able to reproduce it exactly as he described, but I have managed to do so otherwise, and remember it happening on occasion on other computers.This appears to happen because the dialog windows are not being made transient relative to the main window. I'll have a PR up with a fix in a bit.Following is what Irv Kalb sent to the mailing list:I teach Python classes using IDLE. The search dialog is a real a problem for new students and me as the teacher. My students and I often get into a scenario where the search dialog gets hidden behind a editing window. When that happens, then you try to make edits in code and nothing happens. This happens to very often. I have learned to look for the hidden search dialog window, but my students get very flustered.Simple steps to reproduce (I'm using Python 3.6.1 with IDLE):Open a new document.Enter any code (e.g., a = 1)Bring up the Search Dialog.If the Search Dialog is not over the rectangle of the editing window, move it anywhere over the editing window. (This step is specifically to reproduce the problem, but this happens very often as students move windows around.)Search for: a Click: Find NextClick in the editing window (with the intention to make some change)Results:Search Dialog is now hidden behind the editing window. Keystrokes are now ignored in the editing window, even though the editing window appears to have focus.User has no idea about how to get out of this situation - unless they have seen it before and know that the Search Dialog is still active behind the current window. | |||
| msg344832 -(view) | Author: Tal Einat (taleinat)*![]() | Date: 2019-06-06 16:26 | |
See proposed fix inGH-13869. | |||
| msg344898 -(view) | Author: Tal Einat (taleinat)*![]() | Date: 2019-06-07 05:54 | |
New changeset554450fb4e95066e825bdb4a2d544a490daeebdc by Tal Einat in branch 'master':bpo-37177: make IDLE's search dialogs transient (GH-13869)https://github.com/python/cpython/commit/554450fb4e95066e825bdb4a2d544a490daeebdc | |||
| msg344899 -(view) | Author: miss-islington (miss-islington) | Date: 2019-06-07 06:17 | |
New changeset295fe32e393280464feef7c6fb616ea2d1e73e37 by Miss Islington (bot) in branch '3.8':bpo-37177: make IDLE's search dialogs transient (GH-13869)https://github.com/python/cpython/commit/295fe32e393280464feef7c6fb616ea2d1e73e37 | |||
| msg344900 -(view) | Author: miss-islington (miss-islington) | Date: 2019-06-07 06:37 | |
New changeset685b806549cc956aeeb3a57fe15ee5a4d1704aed by Miss Islington (bot) in branch '3.7':bpo-37177: make IDLE's search dialogs transient (GH-13869)https://github.com/python/cpython/commit/685b806549cc956aeeb3a57fe15ee5a4d1704aed | |||
| msg344902 -(view) | Author: Tal Einat (taleinat)*![]() | Date: 2019-06-07 06:53 | |
New changeset1b57ab5c6478b93cf4150bd8c475022252776598 by Tal Einat in branch '2.7':[2.7]bpo-37177: make IDLE's search dialogs transient (GH-13869)https://github.com/python/cpython/commit/1b57ab5c6478b93cf4150bd8c475022252776598 | |||
| msg344913 -(view) | Author: Terry J. Reedy (terry.reedy)*![]() | Date: 2019-06-07 09:16 | |
Irv's steps did not work for me either, on Windows, and I do not know how else to reproduce. So I cannot test that this fixes any hiding issue. However, the patch fixes#24039. On Windows, it removes the inoperative minimize button and the unwanted maximize buttom, making the search dialog work like all the other IDLE dialogs I checked. | |||
| msg345035 -(view) | Author: Tal Einat (taleinat)*![]() | Date: 2019-06-08 13:17 | |
The issue Irv reported happened on macOS but not on Windows. I've reproduced his issue without this fix, and checked that this fix does indeed fix his issue.For future reference, Irv also posted a video showing his issue on YouTube[1] (he sent a link to idle-dev).[1]http://www.youtube.com/watch?v=YWDsOEN8qsE | |||
| msg345051 -(view) | Author: Terry J. Reedy (terry.reedy)*![]() | Date: 2019-06-08 15:27 | |
I saw the email, thanks for testing.Irv, a reminder: All reports of IDLE UI behavior (and some of internal behavior) need to be tagged with OS. Working 'cross-platform' does not mean 'the same across platforms'. In particular, tcl/tk long ago made a decision to adjust to platform conventions (which have sometimes changed ;-). I should have asked 'what OS' when I saw your report. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:16 | admin | set | github: 81358 |
| 2019-06-08 15:27:31 | terry.reedy | set | messages: +msg345051 |
| 2019-06-08 13:17:26 | taleinat | set | messages: +msg345035 |
| 2019-06-07 16:30:38 | SilentGhost | link | issue37197 superseder |
| 2019-06-07 14:32:24 | taleinat | set | pull_requests: -pull_request13768 |
| 2019-06-07 14:26:10 | t-vi | set | pull_requests: +pull_request13768 |
| 2019-06-07 09:16:20 | terry.reedy | set | messages: +msg344913 |
| 2019-06-07 06:53:57 | taleinat | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-06-07 06:53:08 | taleinat | set | messages: +msg344902 |
| 2019-06-07 06:37:35 | miss-islington | set | messages: +msg344900 |
| 2019-06-07 06:17:16 | miss-islington | set | nosy: +miss-islington messages: +msg344899 |
| 2019-06-07 06:08:17 | taleinat | set | pull_requests: +pull_request13758 |
| 2019-06-07 05:55:11 | miss-islington | set | pull_requests: +pull_request13757 |
| 2019-06-07 05:55:04 | miss-islington | set | pull_requests: +pull_request13756 |
| 2019-06-07 05:54:43 | taleinat | set | messages: +msg344898 |
| 2019-06-06 17:40:08 | taleinat | set | nosy: +IrvKalb |
| 2019-06-06 16:26:36 | taleinat | set | messages: +msg344832 |
| 2019-06-06 16:26:01 | taleinat | set | keywords: +patch stage: needs patch -> patch review pull_requests: +pull_request13745 |
| 2019-06-06 16:22:35 | taleinat | set | stage: needs patch type: behavior versions: + Python 2.7, Python 3.7, Python 3.8, Python 3.9 |
| 2019-06-06 16:21:59 | taleinat | create | |