
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2018-11-09 19:09 bythatiparthy, last changed2022-04-11 14:59 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 10438 | merged | thatiparthy,2018-11-09 23:41 | |
| PR 10445 | merged | thatiparthy,2018-11-10 04:36 | |
| PR 10446 | merged | thatiparthy,2018-11-10 06:22 | |
| PR 10447 | merged | miss-islington,2018-11-10 06:45 | |
| PR 10448 | merged | miss-islington,2018-11-10 06:46 | |
| PR 10450 | merged | thatiparthy,2018-11-10 08:10 | |
| PR 10561 | merged | thatiparthy,2018-11-16 05:39 | |
| PR 10573 | merged | thatiparthy,2018-11-16 14:15 | |
| PR 10582 | merged | miss-islington,2018-11-17 06:38 | |
| PR 10583 | merged | miss-islington,2018-11-17 06:38 | |
| Messages (14) | |||
|---|---|---|---|
| msg329548 -(view) | Author: Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) (thatiparthy)* | Date: 2018-11-09 19:09 | |
Please find the modules where we need to remove.codecs.py:1105:5: F401 'encodings' imported but unusedcode.py:298:13: F401 'readline' imported but unusedplatform.py:118:1: F401 'warnings' imported but unusedplatform.py:509:9: F401 'java.lang' imported but unusedpstats.py:562:9: F401 'readline' imported but unusedshutil.py:13:1: F401 'io' imported but unusedsite.py:409:13: F401 'rlcompleter' imported but unusedsite.py:511:13: F401 'sitecustomize' imported but unusedsite.py:531:13: F401 'usercustomize' imported but unusedtrace.py:54:1: F401 're' imported but unusedtyping.py:21:1: F401 'abc' imported but unusedI was just wondering that as a community, do we recommend this practice of cleaning up Or just we keep as is inorder to NOT to break accidental imports? | |||
| msg329553 -(view) | Author: Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) (thatiparthy)* | Date: 2018-11-09 20:11 | |
I have raised a partial PR here -https://github.com/python/cpython/pull/10438; if it is merged please take up the rest of the changes mentioned in the issue description. | |||
| msg329563 -(view) | Author: Eric V. Smith (eric.smith)*![]() | Date: 2018-11-09 22:41 | |
I think we can remove these in 3.8. My understanding of the policy (which I cannot find: the search terms are too generic) is that if a module defines __all__, and the symbol we want to remove isn't in it, then we can remove the symbol in the next feature release without requiring a deprecation period.If a module doesn't define __all__, then we need a deprecation period in order to remove a symbol, unless the symbol is a module, and then we can just remove it in the next feature release. | |||
| msg329564 -(view) | Author: Eric V. Smith (eric.smith)*![]() | Date: 2018-11-09 22:42 | |
Let me restate that: I think we can remove these in 3.8 if they're not in the module's __all__. I haven't checked that, although it would surprise me if any of them were in __all__. | |||
| msg329567 -(view) | Author: Raymond Hettinger (rhettinger)*![]() | Date: 2018-11-09 23:15 | |
There's a few that should be discussed with the module maintainers first. A patch for IDLE should go through Terry Reedy. The "java.lang" in platform isn't a normal import and may have something to do with Jython. The "abc" in typing.py might be there for a reason, so ask Guido before zapping it. It's also possible that "encodings" might be in codecs for a reason as well, but I'm not sure who you should check with. I'm not sure about readline, rlcompleter, sitecustomize, and usercustomize. I think think those imports may be there for their side-effects. Just importing them may suffice to enable some behavior, so be careful with these. | |||
| msg329597 -(view) | Author: Terry J. Reedy (terry.reedy)*![]() | Date: 2018-11-10 06:45 | |
New changeset43a74abb3a87092a7fd6c71042eafb977d70d8e0 by Terry Jan Reedy (Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి)) in branch 'master':bpo-35202: Remove unused imports in idlelib (GH-10438)https://github.com/python/cpython/commit/43a74abb3a87092a7fd6c71042eafb977d70d8e0 | |||
| msg329598 -(view) | Author: miss-islington (miss-islington) | Date: 2018-11-10 07:06 | |
New changeset2847ccae4687cb43334d87d86fb6c11cb14218f5 by Miss Islington (bot) in branch '3.7':bpo-35202: Remove unused imports in idlelib (GH-10438)https://github.com/python/cpython/commit/2847ccae4687cb43334d87d86fb6c11cb14218f5 | |||
| msg329599 -(view) | Author: miss-islington (miss-islington) | Date: 2018-11-10 07:08 | |
New changeset2903b0fd38a65e16ddafae7754ed5d605fea68ff by Miss Islington (bot) in branch '3.6':bpo-35202: Remove unused imports in idlelib (GH-10438)https://github.com/python/cpython/commit/2903b0fd38a65e16ddafae7754ed5d605fea68ff | |||
| msg329603 -(view) | Author: Terry J. Reedy (terry.reedy)*![]() | Date: 2018-11-10 08:02 | |
Srinivas, if you thing the issue is finished, please close it. Otherwise say something about what is left to do. | |||
| msg329604 -(view) | Author: Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) (thatiparthy)* | Date: 2018-11-10 08:20 | |
I have raised one more PR; I think i am done with this issue. People who are interested can take up from here. ,For the record, following are some filters to search;Query to find unused imports----------------------------------find . -type f -name \*.py -print | xargs flake8 | grep F401----------------------------------Search query ------------------------------------grep -v warnings | grep -v "\.\*" | grep -v tkinter | grep -v sysconfig | grep -v readline | grep -v py3_test_grammar.py | grep -v java | grep -v rlcompleter | grep -v sitecustomize | grep -v __all__ | grep -v test_importlib | grep -v async | grep -v test_future | grep -v circular_import | grep -v dataclasses------------------------------------ | |||
| msg329984 -(view) | Author: Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) (thatiparthy)* | Date: 2018-11-16 09:42 | |
With the current PR, i think i removed all unused imports in Lib folder. | |||
| msg330024 -(view) | Author: miss-islington (miss-islington) | Date: 2018-11-17 06:48 | |
New changeset3a600d224c1e1106756cc71639232ae1acae45bd by Miss Islington (bot) in branch '3.7':bpo-35202: Remove more unused imports in idlelib (GH-10573)https://github.com/python/cpython/commit/3a600d224c1e1106756cc71639232ae1acae45bd | |||
| msg330025 -(view) | Author: miss-islington (miss-islington) | Date: 2018-11-17 07:00 | |
New changeset8d816f74d7673c836b16e4423fed0ec6ee510290 by Miss Islington (bot) in branch '3.6':bpo-35202: Remove more unused imports in idlelib (GH-10573)https://github.com/python/cpython/commit/8d816f74d7673c836b16e4423fed0ec6ee510290 | |||
| msg330026 -(view) | Author: Terry J. Reedy (terry.reedy)*![]() | Date: 2018-11-17 07:03 | |
Thank you for the cleanup. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:08 | admin | set | github: 79383 |
| 2018-11-17 07:03:32 | terry.reedy | set | status: open -> closed resolution: fixed messages: +msg330026 stage: patch review -> resolved |
| 2018-11-17 07:00:35 | miss-islington | set | messages: +msg330025 |
| 2018-11-17 06:48:45 | miss-islington | set | messages: +msg330024 |
| 2018-11-17 06:38:23 | miss-islington | set | pull_requests: +pull_request9828 |
| 2018-11-17 06:38:13 | miss-islington | set | pull_requests: +pull_request9827 |
| 2018-11-16 14:15:05 | thatiparthy | set | pull_requests: +pull_request9821 |
| 2018-11-16 09:42:49 | thatiparthy | set | messages: +msg329984 |
| 2018-11-16 05:39:35 | thatiparthy | set | pull_requests: +pull_request9807 |
| 2018-11-10 08:20:08 | thatiparthy | set | messages: +msg329604 |
| 2018-11-10 08:10:40 | thatiparthy | set | pull_requests: +pull_request9725 |
| 2018-11-10 08:02:39 | terry.reedy | set | messages: +msg329603 |
| 2018-11-10 07:08:08 | miss-islington | set | messages: +msg329599 |
| 2018-11-10 07:06:27 | miss-islington | set | nosy: +miss-islington messages: +msg329598 |
| 2018-11-10 06:46:00 | miss-islington | set | pull_requests: +pull_request9723 |
| 2018-11-10 06:45:50 | miss-islington | set | pull_requests: +pull_request9722 |
| 2018-11-10 06:45:35 | terry.reedy | set | messages: +msg329597 |
| 2018-11-10 06:22:41 | thatiparthy | set | pull_requests: +pull_request9721 |
| 2018-11-10 04:36:26 | thatiparthy | set | pull_requests: +pull_request9720 |
| 2018-11-10 01:28:45 | gvanrossum | set | nosy: -gvanrossum |
| 2018-11-09 23:41:36 | thatiparthy | set | pull_requests: +pull_request9715 |
| 2018-11-09 23:15:49 | rhettinger | set | nosy: +gvanrossum,terry.reedy,rhettinger messages: +msg329567 |
| 2018-11-09 22:42:39 | eric.smith | set | messages: +msg329564 |
| 2018-11-09 22:41:32 | eric.smith | set | nosy: +eric.smith messages: +msg329563 versions: + Python 3.8 |
| 2018-11-09 20:11:28 | thatiparthy | set | messages: +msg329553 |
| 2018-11-09 20:10:25 | thatiparthy | set | pull_requests: -pull_request9712 |
| 2018-11-09 19:10:32 | thatiparthy | set | keywords: +patch stage: patch review pull_requests: +pull_request9712 |
| 2018-11-09 19:09:12 | thatiparthy | create | |