➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2018-09-04 04:19 bysir-sigurd, last changed2022-04-11 14:59 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 9051 | merged | sir-sigurd,2018-09-04 04:38 | |
| PR 9996 | merged | miss-islington,2018-10-20 05:21 | |
| PR 9997 | merged | miss-islington,2018-10-20 05:21 | |
| Messages (7) | |||
|---|---|---|---|
| msg324551 -(view) | Author: Sergey Fedoseev (sir-sigurd)* | Date: 2018-09-04 04:19 | |
In [1]: from collections import OrderedDictIn [2]: od = OrderedDict.fromkeys(range(10))In [3]: it = iter(od)In [4]: it.__reduce__()Out[4]: (<function iter>, ([0, 1, 2, 3, 4, 5, 6, 7, 8, 9],))In [5]: list(it)Out[5]: [] | |||
| msg324650 -(view) | Author: Josh Rosenberg (josh.r)* | Date: 2018-09-05 20:05 | |
This would presumably be a side-effect of all generic pickling operations of iterators; figuring out what the iterator produces requires running out the iterator. You could special case it case-by-case, but that just makes the behavior unreliable/confusing; now some iterators pickle without being mutated, and others don't. Do you have a proposal to fix it? Is it something that needs to be fixed at all, when the option to pickle the original OrderedDict directly is there? | |||
| msg324664 -(view) | Author: Sergey Fedoseev (sir-sigurd)* | Date: 2018-09-06 06:40 | |
Other iterators either don't support pickling or aren't mutated during pickling:In [10]: it = iter({1})In [11]: pickle.dumps(it)Out[11]: b'\x80\x04\x95\x1e\x00\x00\x00\x00\x00\x00\x00\x8c\x08builtins\x94\x8c\x04iter\x94\x93\x94]\x94K\x01a\x85\x94R\x94.'In [12]: list(it)Out[12]: [1]In [13]: it = (x for x in {1})In [14]: pickle.dumps(it)---------------------------------------------------------------------------TypeError Traceback (most recent call last)<ipython-input-14-7e86a183a31c> in <module>()----> 1 pickle.dumps(it)TypeError: can't pickle generator objects | |||
| msg328124 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2018-10-20 05:20 | |
New changeseta5259fb05d03f4871837c14fed704541a20896c0 by Serhiy Storchaka (Sergey Fedoseev) in branch 'master':bpo-34574: Prevent OrderedDict iterators from exhaustion during pickling. (GH-9051)https://github.com/python/cpython/commit/a5259fb05d03f4871837c14fed704541a20896c0 | |||
| msg328126 -(view) | Author: miss-islington (miss-islington) | Date: 2018-10-20 05:54 | |
New changesetdcd56f615e89d4920a0598a9c3d3301701f238a6 by Miss Islington (bot) in branch '3.7':bpo-34574: Prevent OrderedDict iterators from exhaustion during pickling. (GH-9051)https://github.com/python/cpython/commit/dcd56f615e89d4920a0598a9c3d3301701f238a6 | |||
| msg328127 -(view) | Author: miss-islington (miss-islington) | Date: 2018-10-20 06:05 | |
New changeset0d3dd9fe0d2565f09f70d8ea7341dfd88e6bd380 by Miss Islington (bot) in branch '3.6':bpo-34574: Prevent OrderedDict iterators from exhaustion during pickling. (GH-9051)https://github.com/python/cpython/commit/0d3dd9fe0d2565f09f70d8ea7341dfd88e6bd380 | |||
| msg328128 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2018-10-20 06:06 | |
Thank your Sergey for your report and fix. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:05 | admin | set | github: 78755 |
| 2018-10-20 06:06:46 | serhiy.storchaka | set | status: open -> closed versions: + Python 3.6, Python 3.7, Python 3.8 messages: +msg328128 components: + Extension Modules resolution: fixed stage: patch review -> resolved |
| 2018-10-20 06:05:24 | miss-islington | set | messages: +msg328127 |
| 2018-10-20 05:54:13 | miss-islington | set | nosy: +miss-islington messages: +msg328126 |
| 2018-10-20 05:21:11 | miss-islington | set | pull_requests: +pull_request9339 |
| 2018-10-20 05:21:00 | miss-islington | set | pull_requests: +pull_request9338 |
| 2018-10-20 05:20:46 | serhiy.storchaka | set | messages: +msg328124 |
| 2018-09-08 12:32:21 | serhiy.storchaka | set | assignee:serhiy.storchaka nosy: +serhiy.storchaka |
| 2018-09-06 06:51:16 | xtreak | set | nosy: +xtreak |
| 2018-09-06 06:40:38 | sir-sigurd | set | messages: +msg324664 |
| 2018-09-05 20:05:08 | josh.r | set | nosy: +josh.r messages: +msg324650 |
| 2018-09-04 04:38:03 | sir-sigurd | set | keywords: +patch stage: patch review pull_requests: +pull_request8513 |
| 2018-09-04 04:19:39 | sir-sigurd | create | |