➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2018-07-27 19:52 bykayhayen, last changed2022-04-11 14:59 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 8510 | merged | berker.peksag,2018-07-28 08:53 | |
| PR 8538 | merged | miss-islington,2018-07-28 21:03 | |
| Messages (5) | |||
|---|---|---|---|
| msg322510 -(view) | Author: Kay Hayen (kayhayen) | Date: 2018-07-27 19:52 | |
Hello there,building an MSI for my project fails. I am calling it like this: assert subprocess.call( ( sys.executable, "setup.py", "bdist_msi", "--target-version=" + sys.version[:3] ) ) == 0Giving the target version is probably non-sense and from a time, where one script was building multiple MSIs, I no longer do that.and it gives: File "C:\Python37_64\lib\site-packages\setuptools\__init__.py", line 129, in setup return distutils.core.setup(**attrs) File "C:\Python37_64\lib\distutils\core.py", line 148, in setup dist.run_commands() File "C:\Python37_64\lib\distutils\dist.py", line 966, in run_commands self.run_command(cmd) File "C:\Python37_64\lib\distutils\dist.py", line 985, in run_command cmd_obj.run() File "C:\Python37_64\lib\distutils\command\bdist_msi.py", line 256, in run self.add_find_python() File "C:\Python37_64\lib\distutils\command\bdist_msi.py", line 346, in add_find_python if msilib.Win64:AttributeError: module 'msilib' has no attribute 'Win64'This happens for 32 and 64 bit CPython 3.7.0 installations. The same code works for all of 2.7, 3.3 through to 3.6, so this is a regression. Any idea?Thanks,Kay | |||
| msg322513 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2018-07-27 20:08 | |
msilib.Win64 has been removed inhttps://github.com/python/cpython/commit/49ce74efe845a8a91939ff3990a5f233262d3e1f#diff-c762e09a046c2ff3cd91f0643cc58049L12I guess the ``if msilib.Win64:`` clause can be replaced with ``if msilib.AMD64:``. | |||
| msg322591 -(view) | Author: Zachary Ware (zach.ware)* | Date: 2018-07-28 21:02 | |
New changeset11eb1a94704142385ffc07852739863ced8587d2 by Zachary Ware (Berker Peksag) in branch 'master':bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510)https://github.com/python/cpython/commit/11eb1a94704142385ffc07852739863ced8587d2 | |||
| msg322598 -(view) | Author: miss-islington (miss-islington) | Date: 2018-07-29 00:14 | |
New changeset1e98d87961ec752a1623135f4d7e8a41820ae256 by Miss Islington (bot) in branch '3.7':bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510)https://github.com/python/cpython/commit/1e98d87961ec752a1623135f4d7e8a41820ae256 | |||
| msg322612 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2018-07-29 06:51 | |
Thanks for the report! | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:03 | admin | set | github: 78432 |
| 2018-07-29 06:51:31 | berker.peksag | set | status: open -> closed components: + Library (Lib), - Distutils versions: + Python 3.8 nosy: -eric.araujo,dstufft messages: +msg322612 resolution: fixed stage: patch review -> resolved |
| 2018-07-29 00:14:48 | miss-islington | set | nosy: +miss-islington messages: +msg322598 |
| 2018-07-28 21:03:07 | miss-islington | set | pull_requests: +pull_request8055 |
| 2018-07-28 21:02:59 | zach.ware | set | messages: +msg322591 |
| 2018-07-28 08:53:00 | berker.peksag | set | keywords: +patch stage: needs patch -> patch review pull_requests: +pull_request8027 |
| 2018-07-27 20:08:37 | berker.peksag | set | nosy: +berker.peksag,zach.ware messages: +msg322513 keywords: +3.7regression type: crash -> behavior stage: needs patch |
| 2018-07-27 19:52:35 | kayhayen | create | |