➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2018-07-27 07:48 byjdemeyer, last changed2022-04-11 14:59 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 8492 | merged | jdemeyer,2018-07-27 07:54 | |
| Messages (7) | |||
|---|---|---|---|
| msg322469 -(view) | Author: Jeroen Demeyer (jdemeyer)* | Date: 2018-07-27 07:48 | |
In Makefile.pre.in, there is this:# Shared libraries must be installed with executable mode on some systems;# rather than figuring out exactly which, we always give them executable mode.# Also, making them read-only seems to be a good idea...INSTALL_SHARED= ${INSTALL} -m 555Installing libraries read-only is very non-standard (I'm not aware of any other build system which does that). Python should just use the more standard 755 install mode. | |||
| msg322475 -(view) | Author: Inada Naoki (methane)* | Date: 2018-07-27 09:18 | |
Isn't it useful to avoid accidental change while open files with editor for just reading?Is there any real world problem about read-only library? | |||
| msg322476 -(view) | Author: Jeroen Demeyer (jdemeyer)* | Date: 2018-07-27 09:25 | |
> Isn't it useful to avoid accidental change while open files with editor for just reading?Why would that argument apply to a binary file (and only to binary files)?> Is there any real world problem about read-only library?It makes it slightly harder to remove a Python installation. Depending on the OS, you'll get a failure or require some additional confirmation.Furthermore, it's very non-standard. Even if that's not a problem by itself, Python should just install things in the standard way. | |||
| msg322478 -(view) | Author: Jeroen Demeyer (jdemeyer)* | Date: 2018-07-27 09:28 | |
Also, some tools may want to edit the library after installation. Rebasing on Cygwin is an example of that. | |||
| msg322486 -(view) | Author: Inada Naoki (methane)* | Date: 2018-07-27 10:47 | |
On Fri, Jul 27, 2018 at 6:25 PM Jeroen Demeyer <report@bugs.python.org> wrote:> > Isn't it useful to avoid accidental change while open files with editor for just reading?>> Why would that argument apply to a binary file (and only to binary files)?I didn't notice it's used only for binary libraries.> > Is there any real world problem about read-only library?>> It makes it slightly harder to remove a Python installation. Depending on the OS, you'll get a failure or require some additional confirmation.Make sense.> Furthermore, it's very non-standard. Even if that's not a problem by itself, Python should just install things in the standard way.It's not true if there are some merits and there are no real problem. | |||
| msg331412 -(view) | Author: Ned Deily (ned.deily)* | Date: 2018-12-09 07:46 | |
New changeset25648d05ac3d74c436f951579bbb716372fb8cc7 by Ned Deily (jdemeyer) in branch 'master':bpo-34245: install Python shared library with more standard 0755 mode (GH-8492)https://github.com/python/cpython/commit/25648d05ac3d74c436f951579bbb716372fb8cc7 | |||
| msg331413 -(view) | Author: Ned Deily (ned.deily)* | Date: 2018-12-09 07:50 | |
Thanks for the PR. I've merged it for release in 3.8.0. As I commented on the PR, I don't think we should backport this; the current behavior has been around for many years and was working as designed so it's not really a bug. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:03 | admin | set | github: 78426 |
| 2018-12-09 07:50:24 | ned.deily | set | status: open -> closed versions: - Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7 messages: +msg331413 resolution: fixed stage: patch review -> resolved |
| 2018-12-09 07:46:53 | ned.deily | set | nosy: +ned.deily messages: +msg331412 |
| 2018-07-27 10:47:35 | methane | set | messages: +msg322486 |
| 2018-07-27 09:28:36 | jdemeyer | set | messages: +msg322478 |
| 2018-07-27 09:25:46 | jdemeyer | set | messages: +msg322476 |
| 2018-07-27 09:18:14 | methane | set | nosy: +methane messages: +msg322475 |
| 2018-07-27 07:54:31 | jdemeyer | set | keywords: +patch stage: patch review pull_requests: +pull_request8012 |
| 2018-07-27 07:48:30 | jdemeyer | create | |