Movatterモバイル変換


[0]ホーム

URL:


homepage

Issue33135

This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title:Define field prefixes for the various config structs
Type:enhancementStage:resolved
Components:Versions:Python 3.8, Python 3.7
process
Status:closedResolution:fixed
Dependencies:Superseder:
Assigned To:Nosy List: BTaskaya, eric.snow, nanjekyejoannah, ncoghlan, vstinner
Priority:normalKeywords:

Created on2018-03-25 06:10 byncoghlan, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.

Messages (5)
msg314398 -(view)Author: Alyssa Coghlan (ncoghlan)*(Python committer)Date: 2018-03-25 06:10
While working onhttps://bugs.python.org/issue33042, I found it hard to keep track of which kind of config struct a particular piece of code was referencing.As a particularly relevant example, we currently have 3 different "warnoptions" fields: the private-to-main one for reading the command line settings, the "wchar_t *" list in the core config, and the "PyObject *" list object in the main interpreter config (which is also the one aliased as sys.warnoptions).What do you think of adopting a convention where:* the command line fields all gain a "cmd_" prefix* the core config fields all gain a "c_" prefix* the interpreter config fields all gain a "py_" prefixWe'd then have "cmd_warnoptions", "c_warnoptions", and "py_warnoptions" as the field names, and it would be more self-evident which layer we were working at in any particular piece of code.
msg342562 -(view)Author: Batuhan Taskaya (BTaskaya)*(Python committer)Date: 2019-05-15 11:17
+1 from me. But i dont understand why this issue triaged as "needs patch". Isn't it should be discussed first?
msg342574 -(view)Author: STINNER Victor (vstinner)*(Python committer)Date: 2019-05-15 14:19
In the master branch, the C function config_read_cmdline() uses:* cmdline_warnoptions: -W command line arguments* env_warnoptions: PYTHONWARNINGS environment variableThe config_init_warnoptions() uses these 2 list and combine it with other options, dev_mode and bytes_warnings.The warnings options are now specified in myPEP 587:https://www.python.org/dev/peps/pep-0587/#priority-and-rules
msg343646 -(view)Author: STINNER Victor (vstinner)*(Python committer)Date: 2019-05-27 15:31
> As a particularly relevant example, we currently have 3 different "warnoptions" fields: the private-to-main one for reading the command line settings, the "wchar_t *" list in the core config, and the "PyObject *" list object in the main interpreter config (which is also the one aliased as sys.warnoptions).This issue has been fixed inbpo-36763 with the implementation of thePEP 587. PyConfig.warnoptions is now an unified list of warnings options. Moreover, the priority of warnings options is now defined at:https://www.python.org/dev/peps/pep-0587/#priority-and-rules
msg353519 -(view)Author: STINNER Victor (vstinner)*(Python committer)Date: 2019-09-30 00:30
(Oops, I posted a comment to the wrong issue, it was a comment forbpo-38317.)
History
DateUserActionArgs
2022-04-11 14:58:59adminsetgithub: 77316
2019-09-30 00:30:42vstinnersetmessages: +msg353519
2019-09-30 00:30:12vstinnersetmessages: -msg353517
2019-09-30 00:29:25vstinnersetmessages: +msg353517
2019-05-27 15:31:08vstinnersetstatus: open -> closed
resolution: fixed
messages: +msg343646

stage: needs patch -> resolved
2019-05-15 14:19:54vstinnersetmessages: +msg342574
2019-05-15 11:17:47BTaskayasetnosy: +BTaskaya
messages: +msg342562
2019-04-19 20:39:51nanjekyejoannahsetnosy: +nanjekyejoannah
2018-03-25 06:10:23ncoghlancreate
Supported byThe Python Software Foundation,
Powered byRoundup
Copyright © 1990-2022,Python Software Foundation
Legal Statements

[8]ページ先頭

©2009-2025 Movatter.jp