➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2017-10-07 14:19 byOren Milman, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 5009 | merged | yselivanov,2017-12-25 16:11 | |
| Messages (4) | |||
|---|---|---|---|
| msg303878 -(view) | Author: Oren Milman (Oren Milman)* | Date: 2017-10-07 14:19 | |
The following code causes an assertion failure in FutureObj_finalize() (inModules/_asynciomodule.c):import asyncioasyncio.Future()._log_traceback = TrueMaybe we should allow Python code to only set it to False, and raise aValueError in case Python code tries to set it to True?(PR 2050 made _log_traceback writable. Are there any usecases for setting it toTrue from Python code?) | |||
| msg309036 -(view) | Author: Andrew Svetlov (asvetlov)* | Date: 2017-12-25 12:44 | |
_log_traceback is a private property and asyncio implementation detail, you should never touch it. | |||
| msg309038 -(view) | Author: Yury Selivanov (yselivanov)* | Date: 2017-12-25 16:08 | |
> _log_traceback is a private property and asyncio implementation detail, you should never touch it.But still, we shouldn't let Python crash if someone sets it. I'll make a PR to fix this the way Oren proposed.Andrew, let's discuss later with what we want to replace _log_traceback. I don't like that it's a semi-public thing. | |||
| msg309042 -(view) | Author: Yury Selivanov (yselivanov)* | Date: 2017-12-25 21:16 | |
New changesete0aef4f3cd339a405d2a7fbd35a50afa64834f84 by Yury Selivanov in branch 'master':bpo-31721: Allow Future._log_traceback to only be set to False (#5009)https://github.com/python/cpython/commit/e0aef4f3cd339a405d2a7fbd35a50afa64834f84 | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:53 | admin | set | github: 75902 |
| 2017-12-25 21:16:59 | yselivanov | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2017-12-25 21:16:13 | yselivanov | set | messages: +msg309042 |
| 2017-12-25 16:11:43 | yselivanov | set | status: closed -> open resolution: wont fix -> (no value) stage: resolved -> patch review |
| 2017-12-25 16:11:22 | yselivanov | set | pull_requests: +pull_request4898 |
| 2017-12-25 16:08:39 | yselivanov | set | messages: +msg309038 |
| 2017-12-25 12:44:02 | asvetlov | set | status: open -> closed nosy: +asvetlov messages: +msg309036 resolution: wont fix stage: resolved |
| 2017-10-07 14:19:24 | Oren Milman | create | |