➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2017-08-21 16:04 byvstinner, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 3167 | merged | vstinner,2017-08-21 16:12 | |
| PR 3178 | merged | vstinner,2017-08-22 10:41 | |
| PR 3253 | merged | vstinner,2017-08-31 13:54 | |
| PR 3521 | merged | vstinner,2017-09-12 23:49 | |
| PR 3522 | merged | python-dev,2017-09-13 00:06 | |
| Messages (8) | |||
|---|---|---|---|
| msg300634 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-08-21 16:04 | |
UsingPR 3138 ofbpo-31234, I noticed that test_concurrent_futures leaks dangling threads:haypo@selma$ ./python -u -m test --fail-env-changed test_concurrent_futures -v -m ThreadPoolWaitTests== CPython 3.7.0a0 (heads/master:0267128, Aug 21 2017, 17:23:11) [GCC 6.4.1 20170727 (Red Hat 6.4.1-1)](...)test_all_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... Warning -- threading_cleanup() detected 0 leaked threads (count: 0, dangling: 6)0.11s oktest_first_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... 1.60s oktest_first_completed_some_already_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... 1.60s oktest_first_exception (test.test_concurrent_futures.ThreadPoolWaitTests) ... Warning -- threading_cleanup() detected 0 leaked threads (count: 0, dangling: 6)3.11s oktest_first_exception_one_already_failed (test.test_concurrent_futures.ThreadPoolWaitTests) ... 2.10s oktest_first_exception_some_already_complete (test.test_concurrent_futures.ThreadPoolWaitTests) ... Warning -- threading_cleanup() detected 0 leaked threads (count: 0, dangling: 6)1.60s oktest_pending_calls_race (test.test_concurrent_futures.ThreadPoolWaitTests) ... 0.12s oktest_timeout (test.test_concurrent_futures.ThreadPoolWaitTests) ... 6.11s ok(...) | |||
| msg300651 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-08-21 21:24 | |
New changeset489d91c61d02f401551966f1558ee2dc87fc0ad9 by Victor Stinner in branch 'master':bpo-31249: test_concurrent_futures checks dangling threads (#3167)https://github.com/python/cpython/commit/489d91c61d02f401551966f1558ee2dc87fc0ad9 | |||
| msg300697 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-08-22 14:50 | |
New changesetbc61315377056fe362b744d9c44e17cd3178ce54 by Victor Stinner in branch 'master':bpo-31249: Fix ref cycle in ThreadPoolExecutor (#3178)https://github.com/python/cpython/commit/bc61315377056fe362b744d9c44e17cd3178ce54 | |||
| msg301098 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-09-01 12:46 | |
New changeset60f3f1fb5cbf5354c3081138be806c56cb04153f by Victor Stinner in branch '3.6':bpo-31249: Fix ref cycle in ThreadPoolExecutor (#3253)https://github.com/python/cpython/commit/60f3f1fb5cbf5354c3081138be806c56cb04153f | |||
| msg302007 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-09-12 23:33 | |
I still see the warning sometimes:0:04:09 load avg: 7.03 [185/405/1] test_concurrent_futures failed (env changed) (68 sec) -- running: test_multiprocessing_spawn (160 sec), test_gdb (53 sec), test_lib2to3 (195 sec)test_cancel (test.test_concurrent_futures.FutureTests) ... oktest_cancelled (test.test_concurrent_futures.FutureTests) ... oktest_done (test.test_concurrent_futures.FutureTests) ... oktest_done_callback_already_cancelled (test.test_concurrent_futures.FutureTests) ... oktest_done_callback_already_failed (test.test_concurrent_futures.FutureTests) ... oktest_done_callback_already_successful (test.test_concurrent_futures.FutureTests) ... oktest_done_callback_raises (test.test_concurrent_futures.FutureTests) ... oktest_done_callback_with_cancel (test.test_concurrent_futures.FutureTests) ... oktest_done_callback_with_exception (test.test_concurrent_futures.FutureTests) ... oktest_done_callback_with_result (test.test_concurrent_futures.FutureTests) ... oktest_exception_with_success (test.test_concurrent_futures.FutureTests) ... oktest_exception_with_timeout (test.test_concurrent_futures.FutureTests) ... oktest_repr (test.test_concurrent_futures.FutureTests) ... oktest_result_with_cancel (test.test_concurrent_futures.FutureTests) ... oktest_result_with_success (test.test_concurrent_futures.FutureTests) ... oktest_result_with_timeout (test.test_concurrent_futures.FutureTests) ... oktest_running (test.test_concurrent_futures.FutureTests) ... oktest_correct_timeout_exception_msg (test.test_concurrent_futures.ProcessPoolAsCompletedTests) ... 0.15s oktest_duplicate_futures (test.test_concurrent_futures.ProcessPoolAsCompletedTests) ... 2.16s oktest_free_reference_yielded_future (test.test_concurrent_futures.ProcessPoolAsCompletedTests) ... 0.15s oktest_no_timeout (test.test_concurrent_futures.ProcessPoolAsCompletedTests) ... 0.15s oktest_zero_timeout (test.test_concurrent_futures.ProcessPoolAsCompletedTests) ... 2.15s oktest_free_reference (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.17s oktest_killed_child (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.15s oktest_map (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.18s oktest_map_chunksize (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.17s oktest_map_exception (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.17s oktest_map_timeout (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 6.16s oktest_max_workers_negative (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.14s oktest_no_stale_references (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.14s oktest_shutdown_race_issue12456 (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.15s oktest_submit (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.14s oktest_submit_keyword (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.13s oktest_traceback (test.test_concurrent_futures.ProcessPoolExecutorTest) ... 0.15s oktest_context_manager_shutdown (test.test_concurrent_futures.ProcessPoolShutdownTest) ... 0.07s oktest_del_shutdown (test.test_concurrent_futures.ProcessPoolShutdownTest) ... 0.05s Warning -- threading_cleanup() detected 1 leaked threads (count: 1, dangling: 2)oktest_hang_issue12364 (test.test_concurrent_futures.ProcessPoolShutdownTest) ... 1.09s oktest_interpreter_shutdown (test.test_concurrent_futures.ProcessPoolShutdownTest) ... 2.67s oktest_processes_terminate (test.test_concurrent_futures.ProcessPoolShutdownTest) ... 0.05s oktest_run_after_shutdown (test.test_concurrent_futures.ProcessPoolShutdownTest) ... 0.00s oktest_all_completed (test.test_concurrent_futures.ProcessPoolWaitTests) ... 0.16s oktest_first_completed (test.test_concurrent_futures.ProcessPoolWaitTests) ... 1.64s oktest_first_completed_some_already_completed (test.test_concurrent_futures.ProcessPoolWaitTests) ... 1.65s oktest_first_exception (test.test_concurrent_futures.ProcessPoolWaitTests) ... 3.15s oktest_first_exception_one_already_failed (test.test_concurrent_futures.ProcessPoolWaitTests) ... 2.15s oktest_first_exception_some_already_complete (test.test_concurrent_futures.ProcessPoolWaitTests) ... 1.65s oktest_timeout (test.test_concurrent_futures.ProcessPoolWaitTests) ... 6.15s oktest_correct_timeout_exception_msg (test.test_concurrent_futures.ThreadPoolAsCompletedTests) ... 0.16s oktest_duplicate_futures (test.test_concurrent_futures.ThreadPoolAsCompletedTests) ... 2.15s oktest_free_reference_yielded_future (test.test_concurrent_futures.ThreadPoolAsCompletedTests) ... 0.15s oktest_no_timeout (test.test_concurrent_futures.ThreadPoolAsCompletedTests) ... 0.16s oktest_zero_timeout (test.test_concurrent_futures.ThreadPoolAsCompletedTests) ... 2.15s oktest_default_workers (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.15s oktest_free_reference (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.14s oktest_map (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.15s oktest_map_exception (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.16s oktest_map_submits_without_iteration (test.test_concurrent_futures.ThreadPoolExecutorTest)Tests verifyingissue 11777. ... 0.15s oktest_map_timeout (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 6.13s oktest_max_workers_negative (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.14s oktest_no_stale_references (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.14s oktest_shutdown_race_issue12456 (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.16s oktest_submit (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.14s oktest_submit_keyword (test.test_concurrent_futures.ThreadPoolExecutorTest) ... 0.14s oktest_context_manager_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 0.07s oktest_del_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 0.04s oktest_hang_issue12364 (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 1.07s oktest_interpreter_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 1.65s oktest_run_after_shutdown (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 0.00s oktest_thread_names_assigned (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 0.05s oktest_thread_names_default (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 0.04s oktest_threads_terminate (test.test_concurrent_futures.ThreadPoolShutdownTest) ... 0.02s oktest_all_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... 0.14s oktest_first_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... 1.65s oktest_first_completed_some_already_completed (test.test_concurrent_futures.ThreadPoolWaitTests) ... 1.65s oktest_first_exception (test.test_concurrent_futures.ThreadPoolWaitTests) ... 3.14s oktest_first_exception_one_already_failed (test.test_concurrent_futures.ThreadPoolWaitTests) ... 2.16s oktest_first_exception_some_already_complete (test.test_concurrent_futures.ThreadPoolWaitTests) ... 1.62s oktest_pending_calls_race (test.test_concurrent_futures.ThreadPoolWaitTests) ... 0.16s oktest_timeout (test.test_concurrent_futures.ThreadPoolWaitTests) ... 6.13s ok----------------------------------------------------------------------Ran 79 tests in 68.182sOK | |||
| msg302011 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-09-13 00:05 | |
New changeset3bcf157c115ba3e48bce62ac8cb13c703475a113 by Victor Stinner in branch 'master':bpo-31249: Fix test_concurrent_futures dangling thread (#3521)https://github.com/python/cpython/commit/3bcf157c115ba3e48bce62ac8cb13c703475a113 | |||
| msg302016 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-09-13 00:43 | |
New changeset94eb2d5b73d07bc447f1fe19923b4c3259734b9c by Victor Stinner (Miss Islington (bot)) in branch '3.6':[3.6]bpo-31249: Fix test_concurrent_futures dangling thread (GH-3521) (#3522)https://github.com/python/cpython/commit/94eb2d5b73d07bc447f1fe19923b4c3259734b9c | |||
| msg302017 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-09-13 00:45 | |
Ok, the issue should now be fixed in Python 3.6 and master (future 3.7). | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:51 | admin | set | github: 75432 |
| 2017-09-13 00:45:29 | vstinner | set | status: open -> closed resolution: fixed messages: +msg302017 stage: patch review -> resolved |
| 2017-09-13 00:43:47 | vstinner | set | messages: +msg302016 |
| 2017-09-13 00:06:16 | python-dev | set | pull_requests: +pull_request3520 |
| 2017-09-13 00:05:55 | vstinner | set | messages: +msg302011 |
| 2017-09-12 23:49:26 | vstinner | set | keywords: +patch stage: resolved -> patch review pull_requests: +pull_request3519 |
| 2017-09-12 23:33:45 | vstinner | set | status: closed -> open resolution: fixed -> (no value) messages: +msg302007 |
| 2017-09-01 12:49:12 | vstinner | set | status: open -> closed resolution: fixed stage: resolved |
| 2017-09-01 12:46:46 | vstinner | set | messages: +msg301098 |
| 2017-08-31 13:54:53 | vstinner | set | pull_requests: +pull_request3297 |
| 2017-08-22 14:50:45 | vstinner | set | messages: +msg300697 |
| 2017-08-22 13:58:19 | vstinner | set | versions: + Python 3.6 |
| 2017-08-22 10:41:00 | vstinner | set | pull_requests: +pull_request3216 |
| 2017-08-21 21:24:26 | vstinner | set | messages: +msg300651 |
| 2017-08-21 16:12:36 | vstinner | set | pull_requests: +pull_request3203 |
| 2017-08-21 16:04:21 | vstinner | set | type: resource usage components: + Tests |
| 2017-08-21 16:04:13 | vstinner | create | |