
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2017-06-14 12:00 byeric.smith, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 2265 | merged | serhiy.storchaka,2017-06-18 05:31 | |
| Messages (9) | |||
|---|---|---|---|
| msg295998 -(view) | Author: Eric V. Smith (eric.smith)*![]() | Date: 2017-06-14 12:00 | |
Now that **kwargs are sorted, it would be better if the error given by a unittest subTest (as implemented in uniitest._case._SubTest) didn't sort the parameters when they're printed, but instead printed them out in order.This might be complicated by the ChainMap that's used as part of the implementation, but it should still be doable.For example, I have code that has: with self.subTest(hash=hash, cmp=cmp, frozen=frozen):But when it errors out, it produces: FAIL: test_hash_rules (tst.TestCase) (cmp=True, frozen=True, hash=None)It would be easier to check my code if the order the values was printed was the same as the order in the self.subTest() call. | |||
| msg296001 -(view) | Author: Eric V. Smith (eric.smith)*![]() | Date: 2017-06-14 12:34 | |
Correction: it's implemented in unittest.case._SubTest, specifically in _subDescription(). | |||
| msg296002 -(view) | Author: Louie Lu (louielu)* | Date: 2017-06-14 12:41 | |
I think the question will be, when using multiple subTest (this is why using ChainMap I think), how to determine their order?: with self.subTest(c=i, b=i, a=i): with self.subTest(b=i, c=50, a=60): self.assertEqual(i, 2)>>> FAIL: test_foo (__main__.Test) (a=60, b=4, c=50) | |||
| msg296003 -(view) | Author: Eric V. Smith (eric.smith)*![]() | Date: 2017-06-14 13:17 | |
Good question.It looks like ChainMap does something I wouldn't expect:>>> for k, v in ChainMap({'a': 0, 'b': 1, 'c': 2}, {'b': 3, 'a': 4}).items():... print(k, v)... b 1a 0c 2Once we define what we'd like the output to look like, I'm sure it would be easy enough to get the order right. | |||
| msg296004 -(view) | Author: Louie Lu (louielu)* | Date: 2017-06-14 13:21 | |
Additional note, the order will changed it random way in ChainMap, e.g.:>>> for k, v in ChainMap({'a': 0, 'b': 1, 'c': 2}, {'b': 3, 'a': 4}).items(): print(k, v)...a 0c 2b 1-----restart---->>> for k, v in ChainMap({'a': 0, 'b': 1, 'c': 2}, {'b': 3, 'a': 4}).items(): print(k, v)...b 1c 2a 0 | |||
| msg296005 -(view) | Author: Eric V. Smith (eric.smith)*![]() | Date: 2017-06-14 13:26 | |
Correct on the order changed with regular dicts. That's why I'm targeting this specifically for Python 3.7 and with **kwargs, where order is guaranteed. We might have to use a structure other than a ChainMap of dicts, like a ChainMap of OrderDicts. | |||
| msg296261 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)*![]() | Date: 2017-06-18 05:34 | |
PR 2265 implements a private subclass of ChainMap that preserves ordering. | |||
| msg296263 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)*![]() | Date: 2017-06-18 06:01 | |
Note that the order of parameters of nested subtests is from inner to outer. | |||
| msg296736 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)*![]() | Date: 2017-06-23 18:47 | |
New changeset48fbe52ac71ea711a4701db909ad1ce2647b09fd by Serhiy Storchaka in branch 'master':bpo-30664: The description of a unittest subtest now preserves the (#2265)https://github.com/python/cpython/commit/48fbe52ac71ea711a4701db909ad1ce2647b09fd | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:47 | admin | set | github: 74849 |
| 2017-06-23 18:52:10 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: resolved |
| 2017-06-23 18:47:42 | serhiy.storchaka | set | messages: +msg296736 |
| 2017-06-18 06:01:21 | serhiy.storchaka | set | messages: +msg296263 |
| 2017-06-18 05:34:13 | serhiy.storchaka | set | nosy: +serhiy.storchaka messages: +msg296261 |
| 2017-06-18 05:31:49 | serhiy.storchaka | set | pull_requests: +pull_request2316 |
| 2017-06-14 13:26:27 | eric.smith | set | messages: +msg296005 |
| 2017-06-14 13:21:21 | louielu | set | messages: +msg296004 |
| 2017-06-14 13:17:12 | eric.smith | set | messages: +msg296003 |
| 2017-06-14 13:12:58 | nitishch | set | nosy: +nitishch |
| 2017-06-14 12:41:34 | louielu | set | nosy: +louielu messages: +msg296002 |
| 2017-06-14 12:34:30 | eric.smith | set | messages: +msg296001 title: Change unittest's _SubTest to not sort its params -> Change unittest's _SubTest to not sort its params when printing test failures |
| 2017-06-14 12:00:09 | eric.smith | create | |