➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2017-06-02 21:09 bysteve.dower, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 1924 | merged | steve.dower,2017-06-02 21:13 | |
| PR 1960 | merged | steve.dower,2017-06-05 23:07 | |
| PR 1969 | merged | vstinner,2017-06-06 15:59 | |
| Messages (9) | |||
|---|---|---|---|
| msg295054 -(view) | Author: Steve Dower (steve.dower)* | Date: 2017-06-02 21:09 | |
faulthandler adds a structured exception handler on Windows so we can dump a Python traceback before crashing. This should only be done for fatal exceptions, but is currently done for some non-fatal exceptions.The current test is `flags & EXCEPTION_NONCONTINUABLE`, which is incorrect (as evidenced by the fact that the check is wrong in its current context and should be `!(flags & EXCEPTION_NONCONTINUABLE)`).Instead, `code & 0x80000000` determines whether the exception is an error. If not, we should skip logging any info. | |||
| msg295055 -(view) | Author: Steve Dower (steve.dower)* | Date: 2017-06-02 21:10 | |
Also, it displays exception codes as decimal, but should be hex. I'll fix that too | |||
| msg295216 -(view) | Author: Steve Dower (steve.dower)* | Date: 2017-06-05 22:54 | |
New changesete6a23c8f9a3ce05b759599696cc131c2d9d147ac by Steve Dower in branch 'master':bpo-30557: faulthandler now correctly filters and displays exception codes on Windows (#1924)https://github.com/python/cpython/commit/e6a23c8f9a3ce05b759599696cc131c2d9d147ac | |||
| msg295217 -(view) | Author: Ned Deily (ned.deily)* | Date: 2017-06-05 23:08 | |
Buildbot failure?http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/521 | |||
| msg295232 -(view) | Author: Steve Dower (steve.dower)* | Date: 2017-06-06 03:07 | |
Thanks. Apparently that "filter out bit 4" thing didn't exist in Win7. Guess I need to track down the actual docs and confirm exactly where that happens.Doesn't break the important functionality though, just the test. I don't know that the exit code is stable when the process crashes, so perhaps I should just test for non-zero. | |||
| msg295272 -(view) | Author: STINNER Victor (vstinner)* | Date: 2017-06-06 16:05 | |
It seems like all 3.x Windows buildbots are red... except of x86 Windows7 3.x.Only on Windows older than 7 SP 1, so on Windows 7 for buildbots, the bit is cleared.I createdhttps://github.com/python/cpython/pull/1969 to try to fix buildbots. | |||
| msg295281 -(view) | Author: Steve Dower (steve.dower)* | Date: 2017-06-06 17:40 | |
New changeset6a1d84e2b37291b7e3bc5ddad14a60aed430e404 by Steve Dower (Victor Stinner) in branch 'master':bpo-30557: Fix test_faulthandler (#1969)https://github.com/python/cpython/commit/6a1d84e2b37291b7e3bc5ddad14a60aed430e404 | |||
| msg295284 -(view) | Author: Steve Dower (steve.dower)* | Date: 2017-06-06 17:49 | |
My backport wasn't merged, so I cherrypicked Victor's fix into that PR. Once the buildbots are green again, I'll merge it. | |||
| msg295301 -(view) | Author: Steve Dower (steve.dower)* | Date: 2017-06-06 20:47 | |
New changeset2bafc0dccac2390a52670ba289878318b6ea0293 by Steve Dower in branch '3.6':[3.6]bpo-30557: faulthandler now correctly filters and displays exception … (#1960)https://github.com/python/cpython/commit/2bafc0dccac2390a52670ba289878318b6ea0293 | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:47 | admin | set | github: 74742 |
| 2017-06-06 20:47:54 | steve.dower | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2017-06-06 20:47:16 | steve.dower | set | messages: +msg295301 |
| 2017-06-06 17:49:55 | steve.dower | set | messages: +msg295284 |
| 2017-06-06 17:40:44 | steve.dower | set | messages: +msg295281 |
| 2017-06-06 16:05:20 | vstinner | set | messages: +msg295272 |
| 2017-06-06 15:59:12 | vstinner | set | pull_requests: +pull_request2035 |
| 2017-06-06 03:07:05 | steve.dower | set | nosy: +eryksun messages: +msg295232 |
| 2017-06-05 23:08:30 | ned.deily | set | nosy: +ned.deily messages: +msg295217 |
| 2017-06-05 23:07:18 | steve.dower | set | pull_requests: +pull_request2031 |
| 2017-06-05 22:54:17 | steve.dower | set | messages: +msg295216 |
| 2017-06-02 21:13:36 | steve.dower | set | pull_requests: +pull_request2004 |
| 2017-06-02 21:10:48 | steve.dower | set | messages: +msg295055 |
| 2017-06-02 21:09:30 | steve.dower | create | |