➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2017-01-17 03:08 bysteven.daprano, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| argparse_nobreak.py | steven.daprano,2017-01-17 03:33 | |||
| argparse-help-non-breaking-spaces.patch | xiang.zhang,2017-01-17 06:06 | review | ||
| argparse-help-non-breaking-spaces-2.patch | xiang.zhang,2017-01-22 04:02 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 552 | closed | dstufft,2017-03-31 16:36 | |
| Messages (11) | |||
|---|---|---|---|
| msg285607 -(view) | Author: Steven D'Aprano (steven.daprano)* | Date: 2017-01-17 03:08 | |
argparse help incorrectly breaks long lines on U+u00A0 NO-BREAK SPACE.The attached script has been run on Python 3.5.3rc1 in a terminal window 80 columns wide, and it produces output:: usage: argparse_nobreak.py [-h] [--no-condensedxxxx] optional arguments: -h, --help show this help message and exit --no-condensedxxxx Disable default font-style: condensed. Also disables "M+ 1M" condensed monospace.I expected the last line should have broken just before the "M+ 1M", rather than in the middle.See also#20491. | |||
| msg285608 -(view) | Author: Steven D'Aprano (steven.daprano)* | Date: 2017-01-17 03:33 | |
Here's a slightly simpler demo, without the (fortunately harmless) typo. | |||
| msg285609 -(view) | Author: Martin Panter (martin.panter)* | Date: 2017-01-17 03:39 | |
Maybe a duplicate ofIssue 16623 | |||
| msg285610 -(view) | Author: Xiang Zhang (xiang.zhang)* | Date: 2017-01-17 04:09 | |
textwrap has been fixed in#20491 but this problem still exists. The reason seems to be that argparse replaces the non-break spaces with spaces:before self.whitespace_matcher.sub'Disable default font-style: condensed. Also disables "M+\\xa01M" condensed monospace.'after self.whitespace_matcher.sub'Disable default font-style: condensed. Also disables "M+ 1M" condensed monospace.' | |||
| msg285611 -(view) | Author: Xiang Zhang (xiang.zhang)* | Date: 2017-01-17 06:06 | |
I think this is a regression when coming to 3.x. In 2.7, r'\s+' is by default in ASCII mode and won't match unicode non-breaking spaces. In 3.x it's by default unicode mode so non-breaking spaces are replaced by spaces. I think we can just use [ \t\n\r\f\v]+.Since here are more active core devs I am going to close#16623 and move this forward here. | |||
| msg285984 -(view) | Author: Xiang Zhang (xiang.zhang)* | Date: 2017-01-22 04:02 | |
v2 addresses the comments. I didn't receive the review notification mail so just saw them today. :-( | |||
| msg285991 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2017-01-22 06:26 | |
LGTM.You perhaps need to change your email provider Xiang. It fails too often. | |||
| msg285994 -(view) | Author: Roundup Robot (python-dev) | Date: 2017-01-22 06:43 | |
New changeset98cde683b9c6 by Xiang Zhang in branch '3.5':Issue#29290: argparse help messages won't wrap at non-breaking spaces.https://hg.python.org/cpython/rev/98cde683b9c6New changeset1754722ec296 by Xiang Zhang in branch '3.6':Issue#29290: Merge 3.5.https://hg.python.org/cpython/rev/1754722ec296New changesetc47a72627f0c by Xiang Zhang in branch 'default':Issue#29290: Merge 3.6.https://hg.python.org/cpython/rev/c47a72627f0c | |||
| msg285995 -(view) | Author: Xiang Zhang (xiang.zhang)* | Date: 2017-01-22 06:45 | |
Thanks Serhiy. BTW,#16623 is about 2.7 and the cause is wrap doesn't handle unicode non-breaking spaces right. So it's not the same thing as here. | |||
| msg293472 -(view) | Author: wim glenn (wim.glenn)* | Date: 2017-05-11 04:16 | |
The test "test_help_non_breaking_spaces" from Zhang's commit fails on my platform (other 1563 tests in the module all pass). Interestingly, if running the entire test suite, it doesn't fail. It's only when executing the test_argparse.py module directly that causes the failure. I guess there is some mutable state, or the test doesn't entirely setup correctly. | |||
| msg293473 -(view) | Author: Xiang Zhang (xiang.zhang)* | Date: 2017-05-11 05:18 | |
I can't reproduce the failure in anyway. :-( Could you do some investigation and give more info? | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:42 | admin | set | github: 73476 |
| 2017-05-11 05:18:55 | xiang.zhang | set | messages: +msg293473 |
| 2017-05-11 04:16:14 | wim.glenn | set | nosy: +wim.glenn messages: +msg293472 |
| 2017-03-31 16:36:26 | dstufft | set | pull_requests: +pull_request999 |
| 2017-01-22 06:45:22 | xiang.zhang | set | status: open -> closed resolution: fixed messages: +msg285995 stage: commit review -> resolved |
| 2017-01-22 06:43:19 | python-dev | set | nosy: +python-dev messages: +msg285994 |
| 2017-01-22 06:26:47 | serhiy.storchaka | set | assignee:xiang.zhang messages: +msg285991 stage: patch review -> commit review |
| 2017-01-22 04:02:55 | xiang.zhang | set | files: +argparse-help-non-breaking-spaces-2.patch messages: +msg285984 stage: patch review |
| 2017-01-17 14:06:01 | peter.otten | set | nosy: +peter.otten |
| 2017-01-17 06:13:07 | xiang.zhang | unlink | issue16623 superseder |
| 2017-01-17 06:09:25 | xiang.zhang | link | issue16623 superseder |
| 2017-01-17 06:06:54 | xiang.zhang | set | files: +argparse-help-non-breaking-spaces.patch versions: + Python 3.6, Python 3.7 nosy: +roysmith,paul.j3,serhiy.storchaka messages: +msg285611 keywords: +patch |
| 2017-01-17 04:09:31 | xiang.zhang | set | nosy: +xiang.zhang messages: +msg285610 |
| 2017-01-17 03:39:55 | martin.panter | set | nosy: +martin.panter messages: +msg285609 |
| 2017-01-17 03:34:21 | steven.daprano | set | files: -argparse_nobreak.py |
| 2017-01-17 03:33:47 | steven.daprano | set | files: +argparse_nobreak.py messages: +msg285608 |
| 2017-01-17 03:08:41 | steven.daprano | create | |