➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2016-11-22 11:42 byvstinner, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| gdb_fastcall.patch | vstinner,2016-11-22 11:42 | review | ||
| gdb_fastcall-2.patch | vstinner,2016-11-22 11:44 | review | ||
| Messages (10) | |||
|---|---|---|---|
| msg281465 -(view) | Author: STINNER Victor (vstinner)* | Date: 2016-11-22 11:42 | |
Python 3.6 has a new C calling convention: "fast calls".python-gdb.py was disabled when compact dict was merged, see issue#27350.Sadly, I missed that fast calls also broke python-gdb.py.Attached patch fixes python-gdb.py, but I failed to fix test_gdb.py. With fast calls and patched python-gdb.py, python-gdb.py is now able to detect the Python frame of the call to the builtin id() function. It's a new feature compared to Python 3.5, but test_gdb.py should be updated to handle that.I will try to fix that later, but in the meanwhile I was interrupted because the fix for compact dict in python-gdb.py failed on buildbots, see:http://bugs.python.org/issue28023#msg281464 | |||
| msg281522 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-11-22 21:55 | |
New changeset752863f96fb8 by Victor Stinner in branch 'default':Issue#28770: Update python-gdb.py for fastcallshttps://hg.python.org/cpython/rev/752863f96fb8 | |||
| msg281523 -(view) | Author: STINNER Victor (vstinner)* | Date: 2016-11-22 22:02 | |
I keep the issue open until the 3.6 branch is reopened for regular bug fixes, like this one. Then I will backport the fix to 3.6. | |||
| msg282603 -(view) | Author: Inada Naoki (methane)* | Date: 2016-12-07 09:16 | |
3.6 branch is reopened | |||
| msg282715 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-12-08 16:17 | |
New changesetf41d02d7da37 by Victor Stinner in branch '3.6':Issue#28770: Update python-gdb.py for fastcallshttps://hg.python.org/cpython/rev/f41d02d7da37 | |||
| msg282716 -(view) | Author: STINNER Victor (vstinner)* | Date: 2016-12-08 16:19 | |
I fixed the issue in Python 3.6 (future 3.6.1). | |||
| msg283402 -(view) | Author: STINNER Victor (vstinner)* | Date: 2016-12-16 14:58 | |
The change was cherry-picked in Python 3.6.0RC2.The issue is now fixed, so I close the issue. | |||
| msg283407 -(view) | Author: Ned Deily (ned.deily)* | Date: 2016-12-16 15:11 | |
Please leave this open until the cherry picking is completed. | |||
| msg283464 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-12-17 04:02 | |
New changesetb0efa88c4cf4 by Victor Stinner in branch '3.6':Issue#28770: Update python-gdb.py for fastcallshttps://hg.python.org/cpython/rev/b0efa88c4cf4 | |||
| msg283467 -(view) | Author: Ned Deily (ned.deily)* | Date: 2016-12-17 05:09 | |
[cherrypicked for 3.6.0rc2] | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:39 | admin | set | github: 72956 |
| 2016-12-17 05:09:56 | ned.deily | set | priority: release blocker -> status: open -> closed messages: +msg283467 stage: resolved |
| 2016-12-17 04:02:00 | python-dev | set | messages: +msg283464 |
| 2016-12-16 15:11:38 | ned.deily | set | status: closed -> open messages: +msg283407 |
| 2016-12-16 14:58:48 | vstinner | set | status: open -> closed messages: +msg283402 |
| 2016-12-16 08:28:44 | ned.deily | set | status: closed -> open |
| 2016-12-16 08:27:49 | ned.deily | set | priority: normal -> release blocker nosy: +ned.deily |
| 2016-12-08 16:19:50 | vstinner | set | status: open -> closed resolution: fixed messages: +msg282716 |
| 2016-12-08 16:17:28 | python-dev | set | messages: +msg282715 |
| 2016-12-07 09:16:54 | methane | set | messages: +msg282603 |
| 2016-11-22 22:02:21 | vstinner | set | messages: +msg281523 |
| 2016-11-22 21:55:36 | python-dev | set | nosy: +python-dev messages: +msg281522 |
| 2016-11-22 11:44:51 | vstinner | set | files: +gdb_fastcall-2.patch |
| 2016-11-22 11:43:14 | vstinner | set | nosy: +methane |
| 2016-11-22 11:42:55 | vstinner | create | |