➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2016-09-23 13:31 byArfrever, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| python-use_C_locale.patch | Arfrever,2016-09-23 13:31 | Use C locale | review | |
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 552 | closed | dstufft,2017-03-31 16:36 | |
| Messages (10) | |||
|---|---|---|---|
| msg277277 -(view) | Author: Arfrever Frehtes Taifersar Arahesis (Arfrever)* | Date: 2016-09-23 13:31 | |
When Estonian locale (e.g. et_EE.UTF-8) is set, then the following line in Makefile.pre.in does not match all required strings:sed -e 's,\$$(\([A-Za-z0-9_]*\)),\$$\{\1\},g' <Misc/python-config.sh >python-configIn Estonian locale:[A-Z] does not match: T, U, V, W, X, Y[a-z] does not match: t, u, v, w, x, yhttps://en.wikipedia.org/wiki/Estonian_orthographyRun-time result without fix applied:$ LC_ALL=C bash python-config --helppython-config: line 45: LDVERSION: command not foundpython-config: line 49: VERSION: command not foundpython-config: line 51: prefix: command not foundpython-config: line 51: VERSION: command not foundUsage: python-config --prefix|--exec-prefix|--includes|--libs|--cflags|--ldflags|--extension-suffix|--help|--abiflags|--configdirI attach patch (also fixing distclean target). | |||
| msg277280 -(view) | Author: Arfrever Frehtes Taifersar Arahesis (Arfrever)* | Date: 2016-09-23 14:30 | |
I get "500 Server Error" page when trying to write response in Rietveld, so I will write here...On 2016/09/23 16:00:58, storchaka wrote:>https://bugs.python.org/review/28258/diff/18650/Makefile.pre.in> File Makefile.pre.in (right):> >https://bugs.python.org/review/28258/diff/18650/Makefile.pre.in#newcode1633> Makefile.pre.in:1633: LC_ALL=C; find $(srcdir)/[a-zA-Z]* '(' -name '*.fdc' -o> -name '*~' \> Does it work with ";"?Yes.Expansion is performed here by shell (spawned by make) itself before arguments are passed to find.So LC_ALL=C must be set as a separate command.$ export LC_ALL=et_EE.UTF-8$ mkdir -p /tmp/test/{a,t,z}$ find /tmp/test/[a-zA-Z]*/tmp/test/a/tmp/test/z$ LC_ALL=C find /tmp/test/[a-zA-Z]*/tmp/test/a/tmp/test/z$ LC_ALL=C; find /tmp/test/[a-zA-Z]*/tmp/test/a/tmp/test/t/tmp/test/z$ | |||
| msg277281 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2016-09-23 14:55 | |
Thanks for your explanation, now I see this. The patch LGTM. | |||
| msg277711 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-09-29 17:48 | |
New changeset6110997dd6e7 by Serhiy Storchaka in branch '3.5':Issue#28258: Fixed build with Estonian locale (python-config and distcleanhttps://hg.python.org/cpython/rev/6110997dd6e7New changeset1b9e71f5de83 by Serhiy Storchaka in branch '3.6':Issue#28258: Fixed build with Estonian locale (python-config and distcleanhttps://hg.python.org/cpython/rev/1b9e71f5de83New changeseta2c5179bce01 by Serhiy Storchaka in branch 'default':Issue#28258: Fixed build with Estonian locale (python-config and distcleanhttps://hg.python.org/cpython/rev/a2c5179bce01New changesetf2247d1cb884 by Serhiy Storchaka in branch '2.7':Issue#28258: Fixed build with Estonian locale (distclean target inhttps://hg.python.org/cpython/rev/f2247d1cb884 | |||
| msg277712 -(view) | Author: STINNER Victor (vstinner)* | Date: 2016-09-29 18:19 | |
"LC_ALL=C; find" are you sure for ";"? | |||
| msg277714 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2016-09-29 18:47 | |
This is the question that I asked Arfrever. | |||
| msg277716 -(view) | Author: STINNER Victor (vstinner)* | Date: 2016-09-29 19:36 | |
"Expansion is performed here by shell (spawned by make) itself before arguments are passed to find. So LC_ALL=C must be set as a separate command."Oh. I expected at least "export LANG" somewhere. IMHO it deserves a comment explaining the surprising ";".Does it work if it's written on two lines? | |||
| msg277720 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2016-09-29 19:51 | |
> Oh. I expected at least "export LANG" somewhere. IMHO it deserves a comment> explaining the surprising ";".I don't know if export is needed. I see the same behavior with and without export.> Does it work if it's written on two lines?No, it doesn't work. | |||
| msg277726 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-09-29 20:33 | |
New changeset17f2b6b2e24c by Victor Stinner in branch '3.5':Issue#28258: Explain the LC_ALL change in a commenthttps://hg.python.org/cpython/rev/17f2b6b2e24cNew changesetf256bd5b8418 by Victor Stinner in branch '2.7':Issue#28258: Explain the LC_ALL change in a commenthttps://hg.python.org/cpython/rev/f256bd5b8418 | |||
| msg277810 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2016-10-01 12:23 | |
Thanks Victor! | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:37 | admin | set | github: 72445 |
| 2017-03-31 16:36:25 | dstufft | set | pull_requests: +pull_request989 |
| 2016-10-01 12:23:40 | serhiy.storchaka | set | messages: +msg277810 |
| 2016-09-29 20:33:44 | python-dev | set | messages: +msg277726 |
| 2016-09-29 19:51:19 | serhiy.storchaka | set | messages: +msg277720 |
| 2016-09-29 19:36:53 | vstinner | set | messages: +msg277716 |
| 2016-09-29 18:47:43 | serhiy.storchaka | set | messages: +msg277714 |
| 2016-09-29 18:19:19 | vstinner | set | messages: +msg277712 |
| 2016-09-29 17:48:56 | serhiy.storchaka | set | status: open -> closed versions: + Python 2.7 resolution: fixed assignee:twouters ->serhiy.storchaka type: compile error stage: resolved |
| 2016-09-29 17:48:08 | python-dev | set | nosy: +python-dev messages: +msg277711 |
| 2016-09-23 14:55:52 | serhiy.storchaka | set | messages: +msg277281 |
| 2016-09-23 14:30:40 | Arfrever | set | messages: +msg277280 |
| 2016-09-23 14:01:33 | serhiy.storchaka | set | nosy: +serhiy.storchaka |
| 2016-09-23 13:38:40 | vstinner | set | nosy: +vstinner |
| 2016-09-23 13:31:38 | Arfrever | create | |