➜
This issue trackerhas been migrated toGitHub, and is currentlyread-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on2016-09-21 07:29 byethan.furman, last changed2022-04-11 14:58 byadmin. This issue is nowclosed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| open-gzip.stoneleaf.patch | ethan.furman,2016-09-21 07:29 | review | ||
| issue28227_v2.diff | berker.peksag,2016-10-02 09:12 | review | ||
| issue28227_v3.diff | berker.peksag,2016-10-02 10:19 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 552 | closed | dstufft,2017-03-31 16:36 | |
| Messages (8) | |||
|---|---|---|---|
| msg277110 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2016-09-21 08:36 | |
Since patches for gzip, bz2 and lzma are too similar, I think it is worth to merge them in one patch. | |||
| msg277865 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2016-10-02 09:12 | |
I've addressed all of Serhiy's review comments. Thanks! | |||
| msg277876 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2016-10-02 10:03 | |
You missed one my comment. GzipFile.name is not converted in write mode. | |||
| msg277879 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2016-10-02 10:19 | |
You're right. I definitely missed that one. Here is an updated patch. Thanks again! | |||
| msg277881 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2016-10-02 10:21 | |
By the way, for some reason it doesn't show up athttps://bugs.python.org/review/28227/patch/18629/74286 | |||
| msg277883 -(view) | Author: Serhiy Storchaka (serhiy.storchaka)* | Date: 2016-10-02 10:38 | |
The patch LGTM. | |||
| msg277884 -(view) | Author: Roundup Robot (python-dev) | Date: 2016-10-02 10:46 | |
New changeset3f71d1a93053 by Berker Peksag in branch '3.6':Issue#28227: gzip now supports pathlibhttps://hg.python.org/cpython/rev/3f71d1a93053New changesetb244bf74b638 by Berker Peksag in branch 'default':Issue#28227: Merge from 3.6https://hg.python.org/cpython/rev/b244bf74b638 | |||
| msg277885 -(view) | Author: Berker Peksag (berker.peksag)* | Date: 2016-10-02 10:47 | |
Thanks Ethan and Serhiy. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:37 | admin | set | github: 72414 |
| 2017-03-31 16:36:14 | dstufft | set | pull_requests: +pull_request894 |
| 2016-10-02 10:47:36 | berker.peksag | set | status: open -> closed resolution: fixed messages: +msg277885 stage: commit review -> resolved |
| 2016-10-02 10:46:52 | python-dev | set | nosy: +python-dev messages: +msg277884 |
| 2016-10-02 10:38:25 | serhiy.storchaka | set | assignee:berker.peksag messages: +msg277883 stage: patch review -> commit review |
| 2016-10-02 10:21:56 | berker.peksag | set | messages: +msg277881 |
| 2016-10-02 10:19:41 | berker.peksag | set | files: +issue28227_v3.diff messages: +msg277879 |
| 2016-10-02 10:03:06 | serhiy.storchaka | set | messages: +msg277876 |
| 2016-10-02 09:12:15 | berker.peksag | set | files: +issue28227_v2.diff messages: +msg277865 |
| 2016-10-01 02:09:07 | berker.peksag | set | nosy: +berker.peksag |
| 2016-09-23 21:33:28 | ned.deily | set | nosy: +ned.deily versions: + Python 3.6, Python 3.7 |
| 2016-09-21 08:36:13 | serhiy.storchaka | set | messages: +msg277110 |
| 2016-09-21 08:33:01 | serhiy.storchaka | set | nosy: +serhiy.storchaka |
| 2016-09-21 07:29:26 | ethan.furman | create | |